assorted proof-related followups#10375
Merged
Gargron merged 1 commit intomastodon:masterfrom Mar 28, 2019
Merged
Conversation
Gargron
reviewed
Mar 25, 2019
0813d51 to
936a67a
Compare
Gargron
reviewed
Mar 28, 2019
Member
There was a problem hiding this comment.
This method should have a ? at the end for readability. Could also just name it publish_proof? for simplicity
Gargron
reviewed
Mar 28, 2019
Member
|
Save for the few comments I left, looks fine to me. You should be aware the web UI profile component changed in master (#10337) so you have merge conflicts right now. |
936a67a to
a784165
Compare
Contributor
Author
|
thanks @Gargron. conflict fixed. and i like those UI changes on master. |
Gargron
approved these changes
Mar 28, 2019
hiyuki2578
pushed a commit
to ProjectMyosotis/mastodon
that referenced
this pull request
Oct 2, 2019
messenjahofchrist
pushed a commit
to Origin-Creative/mastodon
that referenced
this pull request
Jul 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
here's what that last change looks like in the UI

and then the post
