Skip to content

assorted proof-related followups#10375

Merged
Gargron merged 1 commit intomastodon:masterfrom
xgess:xgess/improofments
Mar 28, 2019
Merged

assorted proof-related followups#10375
Gargron merged 1 commit intomastodon:masterfrom
xgess:xgess/improofments

Conversation

@xgess
Copy link
Copy Markdown
Contributor

@xgess xgess commented Mar 25, 2019

  • check the environment for some keybase-specific configs before using the current defaults. this is just nice for development.
  • update the identity proof model to trigger the worker on updates as well as creates to handle the case where a user revokes and then re-proves the same identity
  • in the case where a user is trying to prove a different mastodon account than the one they're logged into, catch that a little earlier and show a helpful error message.
  • 2 little tweaks to the hosted keybase configs that make them easier for keybase to consume
  • fix a bug where the very long name of a mastodon instance or a proof provider can overflow in the new proof UI and look bad
  • add active proofs to the account panel on the dashboard just like on the profile page
  • add an option to post a new status during the identity proof creation flow.

here's what that last change looks like in the UI
Screen Shot 2019-03-25 at 4 42 52 PM

and then the post
Screen Shot 2019-03-25 at 4 49 01 PM

Comment thread app/serializers/rest/account_serializer.rb Outdated
Comment thread app/views/settings/identity_proofs/new.html.haml Outdated
@xgess xgess force-pushed the xgess/improofments branch from 0813d51 to 936a67a Compare March 27, 2019 21:58
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method should have a ? at the end for readability. Could also just name it publish_proof? for simplicity

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

accountId is already a string

@Gargron
Copy link
Copy Markdown
Member

Gargron commented Mar 28, 2019

Save for the few comments I left, looks fine to me. You should be aware the web UI profile component changed in master (#10337) so you have merge conflicts right now.

@xgess xgess force-pushed the xgess/improofments branch from 936a67a to a784165 Compare March 28, 2019 14:24
@xgess
Copy link
Copy Markdown
Contributor Author

xgess commented Mar 28, 2019

thanks @Gargron. conflict fixed. and i like those UI changes on master.

@Gargron Gargron merged commit 69141dc into mastodon:master Mar 28, 2019
hiyuki2578 pushed a commit to ProjectMyosotis/mastodon that referenced this pull request Oct 2, 2019
messenjahofchrist pushed a commit to Origin-Creative/mastodon that referenced this pull request Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants