Put poll options behind content warnings#10983
Conversation
|
Added the icon to the public pages
This also fixes the styling of the CW to be the same as in the WebUI ( |
|
Realistically is there any point in adding a new icon inside the show more button? GlitchSoc has that convention because you hide images behind that as well, but in upstream this would be a new precedent and I'm not sure it's actually necessary... |
|
Well, it's not necessary, but it provides meaningful information, as “the poll is an integral part of the status” (can't find it right now but you said something along those lines when we first discussed hiding them)
|
|
That is true, I just feel like that icon is way too tight in there. An alternative idea could be writing "Poll attached" in the same style as "Show thread", there is precedent for previewing hidden content on a separate line like with mentions. |
|
I guess this is a possibility but that would be *in addition* to mentions, and that would probably be a pain to implement on public pages.
|
ClearlyClaire
force-pushed
the
features/polls-behind-cws
branch
from
4f52730 to
b7192df
Compare
|
I'd be more comfortable merging this right now if it didn't change how the "show more" button looked. It can always be adjusted later if need arises. |
|
ok, let me change that |
ClearlyClaire
force-pushed
the
features/polls-behind-cws
branch
from
b7192df to
6e0dae2
Compare
* Put poll options behind CWs in WebUI * Put polls behind CWs on public pages * Add poll icon to public pages CWs * Revert to not showing an icon in the CW button
* Put poll options behind CWs in WebUI * Put polls behind CWs on public pages * Add poll icon to public pages CWs * Revert to not showing an icon in the CW button
2 participants
This moves the whole poll component behind content warnings, in a similar way to what glitch-soc does, but it does not move media components there.
Public pages behave in the same way but don't have the poll icon added yet, because the event handling is more tricky.
Before
After