Fix hidden statuses losing focus#11208
Merged
Gargron merged 1 commit intomastodon:masterfrom Aug 19, 2019
Merged
Conversation
ClearlyClaire
force-pushed
the
fixes/status-list-unloaded-lost-focus
branch
from
5e3c58c to
4226f29
Compare
ykzts
approved these changes
Jun 29, 2019
Member
|
Why should a hidden status keep focus? |
Contributor
Author
|
On chrome, you cannot keep scrolling with keyboard if the item looses focus. For some reason on Firefox this works, though. |
Contributor
Author
|
Also, the status not being selectable makes the column number keyboard shortcuts not scroll to the very top, but to a seemingly-random point of the timeline (actually the first non-hidden status) |
hiyuki2578
pushed a commit
to ProjectMyosotis/mastodon
that referenced
this pull request
Oct 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am not too sure of the performance implications of keeping the
HotKeyscomponent though