Change settings to show restricted accounts only what they have access to#11394
Merged
Gargron merged 1 commit intomastodon:masterfrom Jul 25, 2019
Merged
Conversation
…s to Follow-up to 964ae8e
Member
|
I'm not sure about this, because maybe it's good to show new users what sorts of menu items there are that they will be able to access in the future. On the other hand, it might also be frustrating that they all don't work. |
Contributor
Author
|
I guess we could add some styling and disable those options instead of outright hiding them, but that's more work and I'm not sure it's worth it. Either way, I think it's definitely better not showing non-working links as if they were working |
Gargron
approved these changes
Jul 25, 2019
hiyuki2578
pushed a commit
to ProjectMyosotis/mastodon
that referenced
this pull request
Oct 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to 964ae8e