You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Won't the first request return up to limit + 1 results, and clients would have to use that as offset, but that would skip one database result? And later down the line, the exact match could appear a second time
Okay, first request should now return exactly limit results. To fix the exact match possibly re-appearing later, the account search query methods need to refactored to be composable.
I think this still skips the first result of the second pagination page? Say limit is 3, with one exact match, the service would return, for the first query: the exact match and 2 other results (results 0 and 1 from SQL)
when performing a second query, the client would use an offset of 3, that would return results 3 and 4 from the SQL query, missing the second one
hiyuki2578
pushed a commit
to ProjectMyosotis/mastodon
that referenced
this pull request
Oct 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #11365