Restore hashtag suggestions from local tag history#11632
Merged
Gargron merged 4 commits intomastodon:masterfrom Aug 22, 2019
Merged
Restore hashtag suggestions from local tag history#11632Gargron merged 4 commits intomastodon:masterfrom
Gargron merged 4 commits intomastodon:masterfrom
Conversation
ykzts
reviewed
Aug 21, 2019
ykzts
approved these changes
Aug 21, 2019
Member
It should be possible to fetch the data for those tags |
hiyuki2578
pushed a commit
to ProjectMyosotis/mastodon
that referenced
this pull request
Oct 2, 2019
* Restore hashtag suggestions from local tag history * Append local hashtag suggestions instead of prepending them * Do not display inaccurate usage statistics for hashtags not retrieved from API * Fixup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not happy about mixing
ImmutableJSand native lists/objects here, but it seems like the best way to make it work both for when the REST API hasn't replied yet and for results are gotten from it…EDIT: also not super happy about it claiming there has been 0 uses in the week when the tag data isn't from API resultsExample when
#CatPostingisn't approved (but has been used locally) but#catis: