Change detailed status child ordering to sort self-replies on top#11686
Merged
Gargron merged 1 commit intomastodon:masterfrom Aug 29, 2019
Merged
Change detailed status child ordering to sort self-replies on top#11686Gargron merged 1 commit intomastodon:masterfrom
Gargron merged 1 commit intomastodon:masterfrom
Conversation
Gargron
approved these changes
Aug 29, 2019
umonaca
pushed a commit
to umonaca/mastodon
that referenced
this pull request
Aug 30, 2019
hiyuki2578
pushed a commit
to ProjectMyosotis/mastodon
that referenced
this pull request
Oct 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11679
This will weaken the previous optimization a bit, as it will recompute the descendant ids any time a status change in the redux store.
I'm also not sure this is the most idiomatic way to write it, I mostly translated the Ruby code.