Change trending hashtags to not disappear instantly after midnight#11712
Merged
Change trending hashtags to not disappear instantly after midnight#11712
Conversation
Gargron
force-pushed
the
feature-trending-tags-decay
branch
5 times, most recently
from
718fa24 to
6dcf63a
Compare
Gargron
force-pushed
the
feature-trending-tags-decay
branch
from
6dcf63a to
229e451
Compare
ClearlyClaire
approved these changes
Sep 1, 2019
Contributor
ClearlyClaire
left a comment
ClearlyClaire
left a comment
There was a problem hiding this comment.
Seems good overall, but I have a few reservations (see inline comments).
| end | ||
| end | ||
|
|
||
| users_for_review = User.staff.includes(:account).to_a.select(&:allows_trending_tag_emails?) |
Contributor
There was a problem hiding this comment.
The name is slightly misleading, I was confused this was about reviewing users, and not users that should receive a notification about trending hashtags.
hiyuki2578
pushed a commit
to ProjectMyosotis/mastodon
that referenced
this pull request
Oct 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a hashtag is used, update its counters, and mark it down as used on that day for easy retrieval. Do not calculate the score right then, instead, add a regular scheduler. The scheduler goes over all used hashtags, and hashtags that were previously in the trends, and recalculates their scores. If a score peaks, record the time at which it peaked. Use the peak score, but decay it from the point at which it peaked with a half-life of 6 hours, for the sorting in the trends.
This removes the need to fully reset the trends at midnight, while ensuring that newer trends take precedence over older ones.