Add "not available" label on unknown media attachments#11715
Merged
Conversation
ClearlyClaire
approved these changes
Sep 1, 2019
Contributor
ClearlyClaire
left a comment
ClearlyClaire
left a comment
There was a problem hiding this comment.
This is an improvement overall, but I find it pretty weird to list unsupported attachments in the MediaGallery layout in the first place?
hiyuki2578
pushed a commit
to ProjectMyosotis/mastodon
that referenced
this pull request
Oct 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since unhiding "sensitive media" doesn't actually unhide anything, just always show a "not available" message. This should bring some clarity when e.g. a domain is reject-media-blocked. It would be better to say as much in more words but I don't see a way to add an accessible hint to that interface.