Change deletes to preserve statuses in unresolved reports#11805
Merged
Change deletes to preserve statuses in unresolved reports#11805
Conversation
Gargron
force-pushed
the
feature-keep-statuses-in-reports
branch
from
d4d0af6 to
a613a30
Compare
Gargron
changed the title
Gargron
force-pushed
the
feature-keep-statuses-in-reports
branch
3 times, most recently
from
009854f to
02396a9
Compare
Change all account actions except "none" to resolve all unresolved reports Refactor `SuspendAccountService` to be more readable
Gargron
force-pushed
the
feature-keep-statuses-in-reports
branch
from
02396a9 to
035c260
Compare
ykzts
approved these changes
Sep 11, 2019
hiyuki2578
pushed a commit
to ProjectMyosotis/mastodon
that referenced
this pull request
Oct 2, 2019
mastodon#11805) Change all account actions except "none" to resolve all unresolved reports Refactor `SuspendAccountService` to be more readable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently deletes first perform a soft-delete for immediate API feedback, and then perform a real delete in the background. This change makes it so that the background task keeps statuses that are attached to unresolved reports, as well as making account deletion preserve such statuses as well.
When any account action is performed (warning, disable, silence, suspend), resolve all unresolved reports about that account, except when the action is "none" and connected to a specific report ("mark as resolved"). Resolving a report will fully remove associated soft-deleted statuses.
There is also a refactor of
SuspendAccountServiceto be more readable, since the options to that service have become increasingly confusing.