Skip to content

Fix Move handler queuing jobs that will fail if account is suspended#11864

Merged
Gargron merged 1 commit intomasterfrom
fix-move-handler
Sep 17, 2019
Merged

Fix Move handler queuing jobs that will fail if account is suspended#11864
Gargron merged 1 commit intomasterfrom
fix-move-handler

Conversation

@Gargron
Copy link
Copy Markdown
Member

@Gargron Gargron commented Sep 16, 2019 •
edited
Loading

  • If target account is suspended, exit early instead of queueing jobs that will fail / retry
  • Always set moved-to account in case it's a different than the one before
  • If Move handler could not execute, reset cooldown, to allow trying again
  • Do not unmerge old account from home timelines

@Gargron Gargron added bug Something isn't working performance Runtime performance labels Sep 16, 2019
@Gargron
Fix Move handler queuing jobs that will fail if account is suspended
669372b 
Don't put Move handler on cooldown if it didn't run. Skip unmerging
from timelines to save unnecessary work.
@Gargron Gargron merged commit 38dc51b into master Sep 17, 2019
@Gargron Gargron deleted the fix-move-handler branch September 17, 2019 06:44
noellabo pushed a commit to noellabo/mastodon that referenced this pull request Sep 22, 2019
@Gargron @noellabo
Fix Move handler queuing jobs that will fail if account is suspended (m…
cb7d1e1 
…astodon#11864)

Don't put Move handler on cooldown if it didn't run. Skip unmerging
from timelines to save unnecessary work.
hiyuki2578 pushed a commit to ProjectMyosotis/mastodon that referenced this pull request Oct 2, 2019
@Gargron @hiyuki2578
Fix Move handler queuing jobs that will fail if account is suspended (m…
ad3407a 
…astodon#11864)

Don't put Move handler on cooldown if it didn't run. Skip unmerging
from timelines to save unnecessary work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ykzts ykzts ykzts approved these changes

Assignees

No one assigned

Labels

bug Something isn't working performance Runtime performance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Gargron @ykzts
⚡