Conversation
Gargron
force-pushed
the
feature-conversations-ui
branch
from
4716c32 to
cef691a
Compare
ClearlyClaire
left a comment
ClearlyClaire
left a comment
There was a problem hiding this comment.
Apart from the fav handler thing, LGTM
|
|
||
| const handlers = { | ||
| reply: this.handleReply, | ||
| favourite: this.handleFavourite, |
There was a problem hiding this comment.
slightly weird to have a handler for that when there's nothing in the UI to show the fav state nor do it with something else than the keyboard shortcut
There was a problem hiding this comment.
Oh oops, it isn't hooked up to anything, actually. I'm not sure if the fav button should be there. Don't want it to look too similar to a status. It also doesn't fav the conversation, but the most recent status, so... Not sure.
There was a problem hiding this comment.
yeah, I think it's best without it at all (I notice that glitch-soc's slight redesign of the conversations UI has the same issue: no button—on purpose—but the handler is still on)
Gargron
force-pushed
the
feature-conversations-ui
branch
from
cef691a to
ed9d46c
Compare
Leftover from before mastodon#11896
Leftover from before mastodon#11896
Leftover from before mastodon#11896
2 participants
Fix #11414, fix #9860, fix #10434
There was a bug preventing showing more than 2 avatars. Now 4 avatars can be displayed at once, with anything extra marked with a number label on top. Every participant is listed above the DM individually, and each name is clickable. Attachments are always displayed in list form. The action bar now includes DM-specific items such as deleting the whole conversations or marking it as read (without opening). An option to mute the conversation is more prominent.
Resolve #11839