Remove fallback to long description on sidebar and meta description#12119
Merged
Remove fallback to long description on sidebar and meta description#12119
Conversation
ykzts
approved these changes
Oct 8, 2019
Gargron
force-pushed
the
fix-remove-site-description
branch
from
6e29baa to
071c638
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #12114
This makes behaviour consistent. The long description is returned from API only. Sidebar, meta tags, and frontpage display short description or fallback to a string about Mastodon. That string used to be:
But I feel like that is very dry and too technical, so I am replacing it with the slogan we use in other places:
Small benefit: The "Learn more" button leading to the extended description page is now always displayed on the frontpage.