Fixes featured hashtag setting page erroring out instead of rejecting invalid tags#12436
Merged
Gargron merged 4 commits intomastodon:masterfrom Dec 17, 2019
Merged
Conversation
ClearlyClaire
force-pushed
the
fixes/featured_tags
branch
from
64d68c7 to
7c22419
Compare
Gargron
approved these changes
Dec 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12386
This was caused by
Tag#find_or_create_by_namesraising a validation error because of acreate!call, instead of deferring the validation tosaveas usual.This PR reverts #11621 and applies #11622 instead, as I think
Tag#find_or_create_by_namesshould behave asfind_or_createand such and not callcreate!.