Change audio/video playback to stop playback when out of view#12486
Merged
Change audio/video playback to stop playback when out of view#12486
Conversation
Member
Gargron
commented
Nov 26, 2019
- Change video player to not loop, since the audio player doesn't
- Change playback and mute buttons to feel snappier
Contributor
|
I personally would oppose to this for two main reasons:
|
Member
Author
|
The intersection observer or the reducer do unload the media when it's scrolled away, it's just not immediate. I feel like this way is cleaner, makes it a more consistent behaviour than "keep scrolling and at some point it'll just stop playback, or maybe not until new toots come in from top" |
Change video player to not loop, since the audio player doesn't Change playback and mute buttons to feel snappier
1bb8d63 to
117b46c
Compare
ykzts
approved these changes
Jan 10, 2020
umonaca
added a commit
to umonaca/mastodon
that referenced
this pull request
May 14, 2020
umonaca
added a commit
to umonaca/mastodon
that referenced
this pull request
May 14, 2020
umonaca
added a commit
to umonaca/mastodon
that referenced
this pull request
May 16, 2020
… of view (mastodon#12486)"" This reverts commit 2568dab.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.