Fix error handling in tootctl media remove-orphans#12571
Merged
Conversation
Gargron
force-pushed
the
fix-error-handling-media-remove-orphans
branch
from
2c9ae5a to
dd406e2
Compare
Gargron
force-pushed
the
fix-error-handling-media-remove-orphans
branch
from
dd406e2 to
d5d2c6f
Compare
ykzts
approved these changes
Dec 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In S3 mode: If listing objects fails, output message with the appropriate
--start-afterargument to resume execution in the future. If deleting individual objects fails, log the error and move on.In filesystem mode: If file size or delete fails, log the error and move on.
Do not increase totals before the deletion succeeds.