Hide blocked users from more places

[ClearlyClaire]

Fixes #12732

Because it seemed easier, it also hides muted users and users who blocked us, but whether to do that is debatable.

• hide blocked users from toots' fav list
• hide blocked users from toots' reblogged list
• hide blocked users from account followers (API)
• hide blocked users from account followers (public pages, when logged in)
• hide blocked users from account following (API)
• hide blocked users from account following (public pages, when logged in)

[trwnh]

i'm uneasy with the fact that muted users are hidden too, because when i mute users i only do it because i don't want to see their statuses (and in fact, i make heavy use of the feature that allows to mute a user without muting notifications from them).

i'm also not sure about this because i may want to know whether someone i've blocked is following or followed by someone.

[ClearlyClaire]

i'm uneasy with the fact that muted users are hidden too, because when i mute users i only do it because i don't want to see their statuses (and in fact, i make heavy use of the feature that allows to mute a user without muting notifications from them).

I tend to agree, but:

1. The current code leverages existing caches, and I don't know if it's worth changing just for that
2. Until Add explanations to user block confirmation dialog and add stealth blocks #11562 or similar is merged, we would have no way to completely hide someone without also sending them information about the block

i'm also not sure about this because i may want to know whether someone i've blocked is following or followed by someone.

I don't think that's big of a deal, because that information was already only available through the web interface if either account was on the local instance and the account you were looking did not “hide their network”. Looking at the public pages without logging in is still possible, and I think it's better that this requires that extra step rather than pushing people your purposely blocked on your face.

Also, the same point could have been made about “I want to know if that person boosts that other person I have blocked/muted”

[trwnh]

It's more about the scope of things, really -- mute to me includes content, and blocking adds followship. Really, I think the underlying issue here is that mutes and blocks need a major rework (although i forgot the issue number for that). Muting i guess is more similar to filtering, but by account instead of by keyword. I have some thoughts about that but I should develop them a bit more before sharing -- I'll do so on the appropriate issue.