fix root element of IntersectionObserver#12735
Merged
Gargron merged 1 commit intomastodon:masterfrom Dec 31, 2019
Hidden character warning
The head ref may contain hidden characters: "issue-12455\u2014slow-back-button"
Merged
Conversation
Gargron
reviewed
Dec 30, 2019
panarom
force-pushed
the
issue-12455—slow-back-button
branch
from
9be6819 to
374d2cf
Compare
Gargron
approved these changes
Dec 31, 2019
panarom
added a commit
to panarom/mastodon
that referenced
this pull request
Jan 2, 2020
…lableList is restored" This reverts commit 07e2614. accidentally merged spurious code in mastodon#12661. mastodon#12735 removes the slowdown that this code was trying to solve; and other functionality successfully restores the view state of the list
panarom
added a commit
to panarom/mastodon
that referenced
this pull request
Jan 2, 2020
… identical value" This reverts commit c93df21. accidentally merged spurious code in mastodon#12661. mastodon#12735 removes the slowdown that this code was trying to solve; and other functionality successfully restores the view state of the list
Gargron
pushed a commit
that referenced
this pull request
Jan 2, 2020
* Revert "persist last-intersected status update and restore when ScrollableList is restored" This reverts commit 07e2614. accidentally merged spurious code in #12661. #12735 removes the slowdown that this code was trying to solve; and other functionality successfully restores the view state of the list * Revert "cache currently-viewing status id to avoid calling redux with identical value" This reverts commit c93df21. accidentally merged spurious code in #12661. #12735 removes the slowdown that this code was trying to solve; and other functionality successfully restores the view state of the list
umonaca
pushed a commit
to umonaca/mastodon
that referenced
this pull request
May 14, 2020
…olumn mode (mastodon#12735)" This reverts commit 2a5da8c.
umonaca
pushed a commit
to umonaca/mastodon
that referenced
this pull request
May 14, 2020
…olumn mode (mastodon#12735)" This reverts commit 2a5da8c.
umonaca
pushed a commit
to umonaca/mastodon
that referenced
this pull request
May 16, 2020
…single-column mode (mastodon#12735)"" This reverts commit 99ac41f.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
was previously using the <ScrollableList element, rather than the browser viewport, meaning
• hideIfNotIntersecting was never called
• when going <Back from a status update to a list view (e.g. home timeline), handleIntersection was called on ALL statuses (however many of them) at once, since they were all intersecting with the <ScrollableList element (rather than just the few in the browser viewport)