Fix spurious error and incorrect state change when adding a reaction twice#12957
Merged
Gargron merged 2 commits intomastodon:masterfrom Jan 25, 2020
Merged
Conversation
Gargron
approved these changes
Jan 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the emoji picker, it's easy to add an already-added reaction. Doing so results in the front-end optimistically upping the number, then decrementing it on error, and worse, marking the reaction as not voted by ourselves.
This PR avoids that if we believe we have already voted (this may be out of sync if several clients are involved, so we still try the request—in the worst case, we fail in the same way as before, in other cases we fail gracefully instead of adding distracting visual changes, an error popup, and an incorrect end state)
Also fix the box having an unneeded top border