Add a confirmation dialog when hitting reply and the compose box isn't empty#8893
Merged
Gargron merged 2 commits intomastodon:masterfrom Oct 5, 2018
Merged
Conversation
ClearlyClaire
force-pushed
the
features/reply-confirmation
branch
from
e693833 to
6d58402
Compare
ClearlyClaire
added
the
work in progress
ClearlyClaire
force-pushed
the
features/reply-confirmation
branch
from
e35359d to
02284a5
Compare
ClearlyClaire
removed
the
work in progress
ClearlyClaire
commented
Oct 5, 2018
| 'account', | ||
| 'muted', | ||
| 'hidden', | ||
| 'askReplyConfirmation', |
Contributor
Author
There was a problem hiding this comment.
Thinking about it, I'm not too sure about the performance implications of this. Maybe the mapDispatchToProps thing should be rewritten instead to use getState.
|
Thanks!! <3 |
ClearlyClaire
force-pushed
the
features/reply-confirmation
branch
from
10ed8b9 to
436a8b0
Compare
ykzts
approved these changes
Oct 5, 2018
This was referenced Oct 20, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #878