Remove character counter from edit profile#9100
Merged
Conversation
ykzts
approved these changes
Oct 25, 2018
Member
|
hmm. I think this was a bad idea. we need to fix plurals on weblate, and now we have a check for them. there's no reason to think that avoiding plurals alltogether will help |
Contributor
|
strongly support @nightpool fwiw |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HTML in translation is bad enough given that many translators on Weblate cannot code, but here it's also pluralized, creating issues like #9088. Instead, why not simply limit the input with
maxlength? It's less upfront, but I also think that editing display name / bio comes up less often.