Reduce usage of LD signatures#9659
Merged
Gargron merged 5 commits intomastodon:masterfrom Dec 30, 2018
Merged
Conversation
ClearlyClaire
force-pushed
the
fixes/ld-sign
branch
from
900a18b to
41915ca
Compare
ClearlyClaire
force-pushed
the
fixes/ld-sign
branch
2 times, most recently
from
ffb4272 to
f7e92f1
Compare
ClearlyClaire
changed the title
ClearlyClaire
force-pushed
the
fixes/ld-sign
branch
from
f7e92f1 to
2ce99f7
Compare
Gargron
approved these changes
Dec 30, 2018
hiyuki2578
pushed a commit
to ProjectMyosotis/mastodon
that referenced
this pull request
Oct 2, 2019
* Do not LDS-sign Follow, Accept, Reject, Undo, Block * Do not use LDS for Create activities of private toots * Minor cleanup * Ignore unsigned activities instead of misattributing them * Use status.distributable? instead of querying visibility directly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LDS is used for forwarding replies and deletes, as well as for relays.
There is no need to LDS-sign “private” activities like
Follow,Blocketc., nor signing private toots.Adding tests may be useful…