Skip to content

Commit 116e033

Browse files
authored
fix(evaluator): Update routes url (#928)
1 parent a869545 commit 116e033

File tree

4 files changed

+22
-10
lines changed

4 files changed

+22
-10
lines changed

packages/traceloop-sdk/src/lib/client/evaluator/evaluator.ts

Lines changed: 15 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@ export class Evaluator extends BaseDatasetEntity {
225225
): Promise<EvaluatorExecuteResponse> {
226226
this.validateIdentifier(identifier);
227227
const response = await this.client.post(
228-
`/v2/evaluators/${encodeURIComponent(identifier)}/executions`,
228+
`/v2/evaluators/${encodeURIComponent(identifier)}/execute`,
229229
{ input: options.input },
230230
);
231231
const data = await this.handleResponse(response);
@@ -322,6 +322,7 @@ export class Evaluator extends BaseDatasetEntity {
322322
): Promise<ExecutionResponse[]> {
323323
const {
324324
experimentId,
325+
experimentSlug,
325326
experimentRunId,
326327
taskId,
327328
taskResult,
@@ -333,6 +334,7 @@ export class Evaluator extends BaseDatasetEntity {
333334

334335
const triggerResponse = await this.triggerExperimentEvaluator({
335336
experimentId,
337+
experimentSlug,
336338
experimentRunId,
337339
taskId,
338340
evaluator,
@@ -360,11 +362,17 @@ export class Evaluator extends BaseDatasetEntity {
360362
async triggerExperimentEvaluator(
361363
request: TriggerEvaluatorRequest,
362364
): Promise<TriggerEvaluatorResponse> {
363-
const { experimentId, experimentRunId, taskId, evaluator, taskResult } =
364-
request;
365+
const {
366+
experimentId,
367+
experimentSlug,
368+
experimentRunId,
369+
taskId,
370+
evaluator,
371+
taskResult,
372+
} = request;
365373

366-
if (!experimentId || !taskResult) {
367-
throw new Error("experimentId, evaluator, and taskResult are required");
374+
if (!experimentSlug || !taskResult) {
375+
throw new Error("experimentSlug, evaluator, and taskResult are required");
368376
}
369377

370378
// Handle string, EvaluatorWithVersion, and EvaluatorWithConfig types
@@ -388,6 +396,7 @@ export class Evaluator extends BaseDatasetEntity {
388396
experiment_id: experimentId,
389397
experiment_run_id: experimentRunId,
390398
evaluator_version: evaluatorVersion,
399+
evaluator_slug: evaluatorName,
391400
task_id: taskId,
392401
input_schema_mapping: inputSchemaMapping,
393402
};
@@ -398,7 +407,7 @@ export class Evaluator extends BaseDatasetEntity {
398407
}
399408

400409
const response = await this.client.post(
401-
`/v2/evaluators/slug/${evaluatorName}/execute`,
410+
`/v2/experiments/${experimentSlug}/runs/${experimentRunId}/tasks/${taskId}`,
402411
payload,
403412
);
404413
const data = await this.handleResponse(response);

packages/traceloop-sdk/src/lib/client/experiment/experiment.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -179,6 +179,7 @@ export class Experiment {
179179
const singleEvaluationResult =
180180
await this.evaluator.runExperimentEvaluator({
181181
experimentId: experimentResponse.experiment.id,
182+
experimentSlug: experimentSlug,
182183
experimentRunId: experimentResponse.run.id,
183184
taskId,
184185
evaluator,
@@ -248,7 +249,7 @@ export class Experiment {
248249
};
249250

250251
const response = await this.client.post(
251-
`/v2/experiments/${experimentSlug}/runs/${experimentRunId}/task`,
252+
`/v2/experiments/${experimentSlug}/runs/${experimentRunId}/tasks`,
252253
body,
253254
);
254255

packages/traceloop-sdk/src/lib/interfaces/evaluator.interface.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ export interface StreamEvent {
1010

1111
export interface EvaluatorRunOptions {
1212
experimentId: string;
13+
experimentSlug: string;
1314
experimentRunId?: string;
1415
taskId: string;
1516
taskResult: Record<string, any>;
@@ -29,6 +30,7 @@ export interface EvaluatorResult {
2930

3031
export interface TriggerEvaluatorRequest {
3132
experimentId: string;
33+
experimentSlug: string;
3234
experimentRunId?: string;
3335
taskId?: string;
3436
evaluator: EvaluatorDetails;

packages/traceloop-sdk/test/standalone-evaluators.test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -804,7 +804,7 @@ describe("StandaloneEvaluators", () => {
804804
// ─── run ─────────────────────────────────────────────────────────────────────
805805

806806
describe("run", () => {
807-
it("should POST to /v2/evaluators/:id/executions and return result", async () => {
807+
it("should POST to /v2/evaluators/:id/execute and return result", async () => {
808808
let capturedUrl: string | undefined;
809809
let capturedMethod: string | undefined;
810810
let capturedBody: string | undefined;
@@ -828,7 +828,7 @@ describe("StandaloneEvaluators", () => {
828828

829829
assert.strictEqual(
830830
capturedUrl,
831-
"https://api.traceloop.com/v2/evaluators/eval-123/executions",
831+
"https://api.traceloop.com/v2/evaluators/eval-123/execute",
832832
);
833833
assert.strictEqual(capturedMethod, "POST");
834834
assert.strictEqual(result.executionId, "exec-abc");
@@ -858,7 +858,7 @@ describe("StandaloneEvaluators", () => {
858858

859859
assert.strictEqual(
860860
capturedUrl,
861-
"https://api.traceloop.com/v2/evaluators/quality-judge/executions",
861+
"https://api.traceloop.com/v2/evaluators/quality-judge/execute",
862862
);
863863
});
864864

0 commit comments

Comments
 (0)