Skip to content

Commit 2dcfef8

Browse files
committed
add slug
1 parent 67fb86e commit 2dcfef8

File tree

3 files changed

+9
-4
lines changed

3 files changed

+9
-4
lines changed

packages/traceloop-sdk/src/lib/client/evaluator/evaluator.ts

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -322,6 +322,7 @@ export class Evaluator extends BaseDatasetEntity {
322322
): Promise<ExecutionResponse[]> {
323323
const {
324324
experimentId,
325+
experimentSlug,
325326
experimentRunId,
326327
taskId,
327328
taskResult,
@@ -333,6 +334,7 @@ export class Evaluator extends BaseDatasetEntity {
333334

334335
const triggerResponse = await this.triggerExperimentEvaluator({
335336
experimentId,
337+
experimentSlug,
336338
experimentRunId,
337339
taskId,
338340
evaluator,
@@ -360,11 +362,11 @@ export class Evaluator extends BaseDatasetEntity {
360362
async triggerExperimentEvaluator(
361363
request: TriggerEvaluatorRequest,
362364
): Promise<TriggerEvaluatorResponse> {
363-
const { experimentId, experimentRunId, taskId, evaluator, taskResult } =
365+
const { experimentId, experimentSlug, experimentRunId, taskId, evaluator, taskResult } =
364366
request;
365367

366-
if (!experimentId || !taskResult) {
367-
throw new Error("experimentId, evaluator, and taskResult are required");
368+
if (!experimentSlug || !taskResult) {
369+
throw new Error("experimentSlug, evaluator, and taskResult are required");
368370
}
369371

370372
// Handle string, EvaluatorWithVersion, and EvaluatorWithConfig types
@@ -399,7 +401,7 @@ export class Evaluator extends BaseDatasetEntity {
399401
}
400402

401403
const response = await this.client.post(
402-
`/v2/experiments/${experimentId}/runs/${experimentRunId}/tasks/${taskId}`,
404+
`/v2/experiments/${experimentSlug}/runs/${experimentRunId}/tasks/${taskId}`,
403405
payload,
404406
);
405407
const data = await this.handleResponse(response);

packages/traceloop-sdk/src/lib/client/experiment/experiment.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -179,6 +179,7 @@ export class Experiment {
179179
const singleEvaluationResult =
180180
await this.evaluator.runExperimentEvaluator({
181181
experimentId: experimentResponse.experiment.id,
182+
experimentSlug: experimentSlug,
182183
experimentRunId: experimentResponse.run.id,
183184
taskId,
184185
evaluator,

packages/traceloop-sdk/src/lib/interfaces/evaluator.interface.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ export interface StreamEvent {
1010

1111
export interface EvaluatorRunOptions {
1212
experimentId: string;
13+
experimentSlug: string;
1314
experimentRunId?: string;
1415
taskId: string;
1516
taskResult: Record<string, any>;
@@ -29,6 +30,7 @@ export interface EvaluatorResult {
2930

3031
export interface TriggerEvaluatorRequest {
3132
experimentId: string;
33+
experimentSlug: string;
3234
experimentRunId?: string;
3335
taskId?: string;
3436
evaluator: EvaluatorDetails;

0 commit comments

Comments
 (0)