Skip to content

Commit 7759fb4

Browse files
nirgaclaude
nirga
and
claude
committed
fix: resolve lint errors and warnings
- Add eslint disable comments for required any types - Prefix unused parameters with underscore - Fix syntax errors in try-catch blocks - Address TypeScript warnings 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent ed79220 commit 7759fb4

File tree

3 files changed

+37
-36
lines changed

3 files changed

+37
-36
lines changed

‎packages/instrumentation-langchain/src/callback_handler.ts‎

Lines changed: 34 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,12 @@ import { Tracer, trace, SpanKind, SpanStatusCode, context } from "@opentelemetry
2323
import { SpanAttributes } from "@traceloop/ai-semantic-conventions";
2424

2525
interface SpanData {
26+
// eslint-disable-next-line @typescript-eslint/no-explicit-any
2627
span: any;
2728
runId: string;
2829
}
2930

31+
3032
export class TraceloopCallbackHandler extends BaseCallbackHandler {
3133
name = "traceloop_callback_handler";
3234

@@ -107,11 +109,11 @@ export class TraceloopCallbackHandler extends BaseCallbackHandler {
107109
llm: Serialized,
108110
prompts: string[],
109111
runId: string,
110-
parentRunId?: string,
111-
extraParams?: Record<string, unknown>,
112-
tags?: string[],
113-
metadata?: Record<string, unknown>,
114-
runName?: string
112+
_parentRunId?: string,
113+
_extraParams?: Record<string, unknown>,
114+
_tags?: string[],
115+
_metadata?: Record<string, unknown>,
116+
_runName?: string
115117
): Promise<void> {
116118
const className = llm.id?.[llm.id.length - 1] || "unknown";
117119
const modelName = this.extractModelName(llm);
@@ -146,9 +148,9 @@ export class TraceloopCallbackHandler extends BaseCallbackHandler {
146148
override async handleLLMEnd(
147149
output: LLMResult,
148150
runId: string,
149-
parentRunId?: string,
150-
tags?: string[],
151-
extraParams?: Record<string, unknown>
151+
_parentRunId?: string,
152+
_tags?: string[],
153+
_extraParams?: Record<string, unknown>
152154
): Promise<void> {
153155
// End both LLM and task spans
154156
const llmSpanData = this.spans.get(`${runId}_llm`);
@@ -218,7 +220,7 @@ export class TraceloopCallbackHandler extends BaseCallbackHandler {
218220
const { span: taskSpan } = taskSpanData;
219221

220222
if (this.traceContent && output.generations && output.generations.length > 0) {
221-
const completions = output.generations.map((generation, idx) => {
223+
const completions = output.generations.map((generation, _idx) => {
222224
if (generation && generation.length > 0) {
223225
return generation[0].text;
224226
}
@@ -238,20 +240,20 @@ export class TraceloopCallbackHandler extends BaseCallbackHandler {
238240
async handleChatModelEnd(
239241
output: LLMResult,
240242
runId: string,
241-
parentRunId?: string,
242-
tags?: string[],
243-
extraParams?: Record<string, unknown>
243+
_parentRunId?: string,
244+
_tags?: string[],
245+
_extraParams?: Record<string, unknown>
244246
): Promise<void> {
245247
// Same as handleLLMEnd for chat models
246-
return this.handleLLMEnd(output, runId, parentRunId, tags, extraParams);
248+
return this.handleLLMEnd(output, runId, _parentRunId, _tags, _extraParams);
247249
}
248250

249251
override async handleLLMError(
250252
err: Error,
251253
runId: string,
252-
parentRunId?: string,
253-
tags?: string[],
254-
extraParams?: Record<string, unknown>
254+
_parentRunId?: string,
255+
_tags?: string[],
256+
_extraParams?: Record<string, unknown>
255257
): Promise<void> {
256258
// End both spans on error
257259
const llmSpanData = this.spans.get(`${runId}_llm`);
@@ -278,8 +280,8 @@ export class TraceloopCallbackHandler extends BaseCallbackHandler {
278280
chain: Serialized,
279281
inputs: ChainValues,
280282
runId: string,
281-
parentRunId?: string,
282-
tags?: string[],
283+
_parentRunId?: string,
284+
_tags?: string[],
283285
metadata?: Record<string, unknown>,
284286
runType?: string,
285287
runName?: string
@@ -308,9 +310,9 @@ export class TraceloopCallbackHandler extends BaseCallbackHandler {
308310
override async handleChainEnd(
309311
outputs: ChainValues,
310312
runId: string,
311-
parentRunId?: string,
312-
tags?: string[],
313-
kwargs?: { inputs?: Record<string, unknown> }
313+
_parentRunId?: string,
314+
_tags?: string[],
315+
_kwargs?: { inputs?: Record<string, unknown> }
314316
): Promise<void> {
315317
const spanData = this.spans.get(runId);
316318
if (!spanData) return;
@@ -331,9 +333,9 @@ export class TraceloopCallbackHandler extends BaseCallbackHandler {
331333
override async handleChainError(
332334
err: Error,
333335
runId: string,
334-
parentRunId?: string,
335-
tags?: string[],
336-
kwargs?: { inputs?: Record<string, unknown> }
336+
_parentRunId?: string,
337+
_tags?: string[],
338+
_kwargs?: { inputs?: Record<string, unknown> }
337339
): Promise<void> {
338340
const spanData = this.spans.get(runId);
339341
if (!spanData) return;
@@ -349,10 +351,10 @@ export class TraceloopCallbackHandler extends BaseCallbackHandler {
349351
tool: Serialized,
350352
input: string,
351353
runId: string,
352-
parentRunId?: string,
353-
tags?: string[],
354-
metadata?: Record<string, unknown>,
355-
runName?: string
354+
_parentRunId?: string,
355+
_tags?: string[],
356+
_metadata?: Record<string, unknown>,
357+
_runName?: string
356358
): Promise<void> {
357359
const toolName = tool.id?.[tool.id.length - 1] || "unknown";
358360
const spanName = `${toolName}.task`;
@@ -378,8 +380,8 @@ export class TraceloopCallbackHandler extends BaseCallbackHandler {
378380
override async handleToolEnd(
379381
output: any,
380382
runId: string,
381-
parentRunId?: string,
382-
tags?: string[]
383+
_parentRunId?: string,
384+
_tags?: string[]
383385
): Promise<void> {
384386
const spanData = this.spans.get(runId);
385387
if (!spanData) return;
@@ -400,8 +402,8 @@ export class TraceloopCallbackHandler extends BaseCallbackHandler {
400402
override async handleToolError(
401403
err: Error,
402404
runId: string,
403-
parentRunId?: string,
404-
tags?: string[]
405+
_parentRunId?: string,
406+
_tags?: string[]
405407
): Promise<void> {
406408
const spanData = this.spans.get(runId);
407409
if (!spanData) return;

‎packages/instrumentation-langchain/src/instrumentation.ts‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -56,9 +56,9 @@ export class LangChainInstrumentation extends InstrumentationBase {
5656

5757
if (callbackManagerModule?.CallbackManager) {
5858
this.patchCallbackManager(callbackManagerModule.CallbackManager);
59-
} else {
6059
}
6160
} catch (error) {
61+
this._diag.debug("Error instrumenting callback manager:", error);
6262
}
6363
}
6464

@@ -68,6 +68,7 @@ export class LangChainInstrumentation extends InstrumentationBase {
6868
if (callbackManagerAny._configureSync && !callbackManagerAny._traceloopPatched) {
6969
const originalConfigureSync = callbackManagerAny._configureSync;
7070

71+
// eslint-disable-next-line @typescript-eslint/no-this-alias
7172
const self = this;
7273
callbackManagerAny._configureSync = function (
7374
inheritableHandlers?: unknown[],
@@ -97,8 +98,6 @@ export class LangChainInstrumentation extends InstrumentationBase {
9798

9899
// Mark as patched to avoid double patching
99100
callbackManagerAny._traceloopPatched = true;
100-
} else if (callbackManagerAny._traceloopPatched) {
101-
} else {
102101
}
103102
}
104103

‎packages/instrumentation-langchain/test/instrumentation.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -371,7 +371,7 @@ describe("Test Langchain instrumentation", async function () {
371371
const { z } = await import("zod");
372372

373373
const get_cities_data_by_country = tool(
374-
(_args: {country: string}): object => {
374+
(args: {country: string}): object => {
375375
return [
376376
{
377377
"city": "New York",

0 commit comments

Comments
 (0)
⚡