fix

Author: pritamsoni-hsr

packages/instrumentation-openai/src/attrs.ts

@@ -0,0 +1 @@
+export const ATTR_GEN_AI_REQUEST_REASONING_EFFORT = "gen_ai.request.reasoning_effort";

packages/instrumentation-openai/src/instrumentation.ts

@@ -56,6 +56,7 @@ import { encodingForModel, TiktokenModel, Tiktoken } from "js-tiktoken";
 type APIPromiseType<T> = Promise<T> & {
   _thenUnwrap: <U>(onFulfilled: (value: T) => U) => APIPromiseType<U>;
 };
+import { ATTR_GEN_AI_REQUEST_REASONING_EFFORT } from "./attrs";
 import {
   wrapImageGeneration,
   wrapImageEdit,
@@ -227,19 +228,19 @@ export class OpenAIInstrumentation extends InstrumentationBase {
         const span =
           type === "chat"
             ? plugin.startSpan({
-                type,
-                params: args[0] as ChatCompletionCreateParamsNonStreaming & {
-                  extraAttributes?: Record<string, any>;
-                },
-                client: this,
-              })
+              type,
+              params: args[0] as ChatCompletionCreateParamsNonStreaming & {
+                extraAttributes?: Record<string, any>;
+              },
+              client: this,
+            })
             : plugin.startSpan({
-                type,
-                params: args[0] as CompletionCreateParamsNonStreaming & {
-                  extraAttributes?: Record<string, any>;
-                },
-                client: this,
-              });
+              type,
+              params: args[0] as CompletionCreateParamsNonStreaming & {
+                extraAttributes?: Record<string, any>;
+              },
+              client: this,
+            });
 
         const execContext = trace.setSpan(context.active(), span);
         const execPromise = safeExecuteInTheMiddle(
@@ -261,8 +262,8 @@ export class OpenAIInstrumentation extends InstrumentationBase {
         if (
           (
             args[0] as
-              | ChatCompletionCreateParamsStreaming
-              | CompletionCreateParamsStreaming
+            | ChatCompletionCreateParamsStreaming
+            | CompletionCreateParamsStreaming
           ).stream
         ) {
           return context.bind(
@@ -294,19 +295,19 @@ export class OpenAIInstrumentation extends InstrumentationBase {
     client,
   }:
     | {
-        type: "chat";
-        params: ChatCompletionCreateParamsNonStreaming & {
-          extraAttributes?: Record<string, any>;
-        };
-        client: any;
-      }
+      type: "chat";
+      params: ChatCompletionCreateParamsNonStreaming & {
+        extraAttributes?: Record<string, any>;
+      };
+      client: any;
+    }
     | {
-        type: "completion";
-        params: CompletionCreateParamsNonStreaming & {
-          extraAttributes?: Record<string, any>;
-        };
-        client: any;
-      }): Span {
+      type: "completion";
+      params: CompletionCreateParamsNonStreaming & {
+        extraAttributes?: Record<string, any>;
+      };
+      client: any;
+    }): Span {
     const { provider } = this._detectVendorFromURL(client);
 
     const attributes: Attributes = {
@@ -322,9 +323,6 @@ export class OpenAIInstrumentation extends InstrumentationBase {
       if (params.temperature) {
         attributes[ATTR_GEN_AI_REQUEST_TEMPERATURE] = params.temperature;
       }
-      if ('reasoning_effort' in params){
-        attributes["gen_ai.request.reasoning_effort"] = params.reasoning_effort as string;
-      }
       if (params.top_p) {
         attributes[ATTR_GEN_AI_REQUEST_TOP_P] = params.top_p;
       }
@@ -336,6 +334,13 @@ export class OpenAIInstrumentation extends InstrumentationBase {
         attributes[SpanAttributes.LLM_PRESENCE_PENALTY] =
           params.presence_penalty;
       }
+      if ("reasoning_effort" in params) {
+        if (typeof params.reasoning_effort === "string") {
+          attributes[ATTR_GEN_AI_REQUEST_REASONING_EFFORT] = params.reasoning_effort;
+        } else {
+          attributes[ATTR_GEN_AI_REQUEST_REASONING_EFFORT] = JSON.stringify(params.reasoning_effort);
+        }
+      }
 
       if (
         params.extraAttributes !== undefined &&
@@ -418,17 +423,17 @@ export class OpenAIInstrumentation extends InstrumentationBase {
     promise,
   }:
     | {
-        span: Span;
-        type: "chat";
-        params: ChatCompletionCreateParamsStreaming;
-        promise: APIPromiseType<Stream<ChatCompletionChunk>>;
-      }
+      span: Span;
+      type: "chat";
+      params: ChatCompletionCreateParamsStreaming;
+      promise: APIPromiseType<Stream<ChatCompletionChunk>>;
+    }
     | {
-        span: Span;
-        params: CompletionCreateParamsStreaming;
-        type: "completion";
-        promise: APIPromiseType<Stream<Completion>>;
-      }) {
+      span: Span;
+      params: CompletionCreateParamsStreaming;
+      type: "completion";
+      promise: APIPromiseType<Stream<Completion>>;
+    }) {
     if (type === "chat") {
       const result: ChatCompletion = {
         id: "0",