Skip to content

Commit ed41ff2

Browse files
authored
fix(instrumentation-utils): Add missing modality field to block mappers document cases (#921)
1 parent 4b5d28f commit ed41ff2

File tree

4 files changed

+122
-86
lines changed

4 files changed

+122
-86
lines changed

packages/instrumentation-anthropic/test/content-block-mapper.test.ts

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,7 @@ describe("mapAnthropicContentBlock", () => {
7676
const result = mapAnthropicContentBlock(block);
7777
assert.deepStrictEqual(result, {
7878
type: "blob",
79+
modality: "document",
7980
mime_type: "application/pdf",
8081
content:
8182
"JVBERi0xLjAKMSAwIG9iajw8L1R5cGUvQ2F0YWxvZy9QYWdlcyAyIDAgUj4+ZW5kb2JqCg==",
@@ -87,6 +88,7 @@ describe("mapAnthropicContentBlock", () => {
8788
const result = mapAnthropicContentBlock(block);
8889
assert.deepStrictEqual(result, {
8990
type: "uri",
91+
modality: "document",
9092
mime_type: "application/pdf",
9193
uri: "https://assets.anthropic.com/m/1cd9d098ac3e6467/original/Claude-3-Model-Card-October-Addendum.pdf",
9294
});
@@ -97,6 +99,7 @@ describe("mapAnthropicContentBlock", () => {
9799
const result = mapAnthropicContentBlock(block);
98100
assert.deepStrictEqual(result, {
99101
type: "file",
102+
modality: "document",
100103
file_id: "file_011CNha8iCJcU1wXNR6q4V8w",
101104
});
102105
});
@@ -192,27 +195,28 @@ describe("mapAnthropicContentBlock", () => {
192195
const result = mapAnthropicContentBlock(block);
193196
assert.deepStrictEqual(result, {
194197
type: "blob",
198+
modality: "document",
195199
mime_type: "text/plain",
196200
content: "aGVsbG8=",
197201
});
198202
});
199203

200-
it("document/base64 result has NO modality field", () => {
204+
it("document/base64 result has modality: document", () => {
201205
const block = {
202206
type: "document",
203207
source: { type: "base64", media_type: "application/pdf", data: "abc" },
204208
};
205209
const result = mapAnthropicContentBlock(block) as any;
206-
assert.strictEqual(result.modality, undefined);
210+
assert.strictEqual(result.modality, "document");
207211
});
208212

209-
it("document/file result has NO modality field", () => {
213+
it("document/file result has modality: document", () => {
210214
const block = {
211215
type: "document",
212216
source: { type: "file", file_id: "file_abc" },
213217
};
214218
const result = mapAnthropicContentBlock(block) as any;
215-
assert.strictEqual(result.modality, undefined);
219+
assert.strictEqual(result.modality, "document");
216220
});
217221

218222
it('thinking block maps to type "reasoning" — never "thinking"', () => {

0 commit comments

Comments
 (0)