fix: include dist .mjs for packages with modules declared#425
Merged
nirga merged 1 commit intotraceloop:mainfrom Aug 24, 2024
Merged
fix: include dist .mjs for packages with modules declared#425nirga merged 1 commit intotraceloop:mainfrom
nirga merged 1 commit intotraceloop:mainfrom
Conversation
I also noticed that a couple packages have esm modules built but neither have them declared in `package.json` _nor_ included as `files`, but I wasn't sure if that was intentional. That would more likely be a feature than a fix anyway.
|
|
vargasd
pushed a commit
to vargasd/openllmetry-js
that referenced
this pull request
Aug 26, 2024
As discussed in traceloop#425, adding ESM exports for packages which didn't previously have them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I also noticed that a couple packages have esm modules built but neither have them declared in
package.jsonnor included asfiles, but I wasn't sure if that was intentional. That would more likely be a feature than a fix anyway.If desired, I can add a commit to declare and include those packages too.