Skip to content

fix(sdk): support custom metrics#446

Merged
doronkopit5 merged 2 commits intomainfrom
dk/support_custom_metric
Sep 9, 2024
Merged

fix(sdk): support custom metrics#446
doronkopit5 merged 2 commits intomainfrom
dk/support_custom_metric

Conversation

@doronkopit5
Copy link
Copy Markdown
Member

@doronkopit5 doronkopit5 commented Sep 4, 2024

Support custom metric as a span attribute, may be changed to an OT metric in the future

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Sep 4, 2024

CLA assistant check
All committers have signed the CLA.

@doronkopit5 doronkopit5 marked this pull request as ready for review September 4, 2024 14:33
@doronkopit5 doronkopit5 changed the title feat(sdk): support custom metrics fix(sdk): support custom metrics Sep 4, 2024
Copy link
Copy Markdown

@VadimZaporozhets VadimZaporozhets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@doronkopit5 doronkopit5 merged commit 7c77047 into main Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants