fix: vercel span transform

[avivhalfon]

Important

Refactors span name handling in ai-sdk-transformations.ts by introducing HANDLED_SPAN_NAMES and shouldHandleSpan() for improved clarity and maintainability.

• Refactoring:
  • Introduces HANDLED_SPAN_NAMES constant to map span names in ai-sdk-transformations.ts.
  • Replaces inline span name mapping in transformAiSdkSpanName() with HANDLED_SPAN_NAMES.
• Functions:
  • Adds shouldHandleSpan() to check if a span name is in HANDLED_SPAN_NAMES.
  • Updates transformAiSdkSpan() to use shouldHandleSpan() for early return if span is not handled.

^{This description was created by for 04a6b37. You can customize this summary. It will automatically update as commits are pushed.}

[ellipsis-dev]

Important

Looks good to me! 👍

Reviewed everything up to d4a565a in 1 minute and 21 seconds. Click for details.

• Reviewed 51 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 3 draft comments. View those below.
• Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

1. packages/traceloop-sdk/src/lib/tracing/ai-sdk-transformations.ts:22

• Draft comment:
  transformAiSdkSpanName now unconditionally assigns the new name using HANDLED_SPAN_NAMES[span.name]. Since this function is exported and might be used outside of the guarded flow, consider adding a check (or documenting) that it should only be called for spans whose name is in HANDLED_SPAN_NAMES. This avoids accidental assignment of undefined.
• Reason this comment was not posted:
  Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 20% vs. threshold = 50% The comment raises a valid point about defensive programming since the function is exported. However, the function is already protected by shouldHandleSpan in its main usage. The suggested change would make the function more robust when used independently. But we don't know if that's actually a real use case, and the comment is somewhat speculative about potential issues rather than addressing a concrete problem. I might be undervaluing the importance of defensive programming. Accessing undefined properties can cause runtime errors that are hard to debug. While defensive programming is good, we should trust that users of this SDK will follow the documented patterns. The main usage is already protected, and adding checks everywhere makes code more complex. The comment is speculative about potential misuse rather than addressing a concrete issue. Following our rules about not making speculative comments, we should remove it.

2. packages/traceloop-sdk/src/lib/tracing/ai-sdk-transformations.ts:111

• Draft comment:
  Consider using Object.hasOwnProperty (or a similar explicit check) in shouldHandleSpan to safeguard against prototype chain properties. The 'in' operator may pick up inherited keys accidentally.
• Reason this comment was not posted:
  Confidence changes required: 33% <= threshold 50% None

3. packages/traceloop-sdk/src/lib/tracing/ai-sdk-transformations.ts:115

• Draft comment:
  Good improvement: transformAiSdkSpan now guards against unhandled spans by using shouldHandleSpan. This keeps the transformation logic safe.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50% None

Workflow ID: wflow_dgPMMhjF45VRRnUa

^{You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.}

[ellipsis-dev]

Important

Looks good to me! 👍

Reviewed 04a6b37 in 47 seconds. Click for details.

• Reviewed 30 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 2 draft comments. View those below.
• Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

1. packages/traceloop-sdk/src/lib/tracing/ai-sdk-transformations.ts:20

• Draft comment:
  Guard added to ensure renaming only occurs when span.name is in HANDLED_SPAN_NAMES. This makes the transformation safe and consistent with shouldHandleSpan. Verify that silent no-op for unexpected span names is acceptable.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50% None

2. packages/traceloop-sdk/src/lib/tracing/ai-sdk-transformations.ts:114

• Draft comment:
  Minor formatting update in transformAiSdkSpan (extraneous whitespace removed). No logic change.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50% None

Workflow ID: wflow_B9V1bwjaRyCndGUv

^{You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.}