fix(chromadb,pinecone,weaviate,lancedb,milvus): record exceptions on error spans

When vector DB calls raise exceptions, spans were left in UNSET state
with no error information. Add span.record_exception() and
StatusCode.ERROR to all wrapped call sites. Milvus already set
ERROR_TYPE attribute; this completes the OTel span status.

Fixes #412

Author: Koushik-Salammagari

packages/opentelemetry-instrumentation-chromadb/opentelemetry/instrumentation/chromadb/wrapper.py

@@ -7,6 +7,7 @@
 )
 from opentelemetry.semconv_ai import EventAttributes, Events
 from opentelemetry.semconv_ai import SpanAttributes as AISpanAttributes
+from opentelemetry.trace.status import Status, StatusCode
 import itertools
 import json
 
@@ -61,7 +62,12 @@ def _wrap(tracer, to_wrap, wrapped, instance, args, kwargs):
         elif to_wrap.get("method") == "delete":
             _set_delete_attributes(span, kwargs)
 
-        return_value = wrapped(*args, **kwargs)
+        try:
+            return_value = wrapped(*args, **kwargs)
+        except Exception as e:
+            span.record_exception(e)
+            span.set_status(Status(StatusCode.ERROR, str(e)))
+            raise
         if to_wrap.get("method") == "query":
             _add_query_result_events(span, return_value)
 

packages/opentelemetry-instrumentation-lancedb/opentelemetry/instrumentation/lancedb/wrapper.py

@@ -6,6 +6,7 @@
     _SUPPRESS_INSTRUMENTATION_KEY,
 )
 from opentelemetry.semconv_ai import SpanAttributes as AISpanAttributes
+from opentelemetry.trace.status import Status, StatusCode
 
 
 def _with_tracer_wrapper(func):
@@ -45,7 +46,12 @@ def _wrap(tracer, to_wrap, wrapped, instance, args, kwargs):
         elif to_wrap.get("method") == "delete":
             _set_delete_attributes(span, kwargs)
 
-        return_value = wrapped(*args, **kwargs)
+        try:
+            return_value = wrapped(*args, **kwargs)
+        except Exception as e:
+            span.record_exception(e)
+            span.set_status(Status(StatusCode.ERROR, str(e)))
+            raise
 
     return return_value
 

packages/opentelemetry-instrumentation-milvus/opentelemetry/instrumentation/milvus/wrapper.py

@@ -9,6 +9,7 @@
 from opentelemetry.semconv_ai import Events, EventAttributes
 from opentelemetry.semconv_ai import SpanAttributes as AISpanAttributes
 
+from opentelemetry.trace.status import Status as SpanStatus, StatusCode
 from pymilvus.client.types import Status
 from pymilvus.exceptions import ErrorCode
 
@@ -112,6 +113,8 @@ def _wrap(
                 getattr(e, "code", None), type(e).__name__
             )
             span.set_attribute(ERROR_TYPE, error_type)
+            span.record_exception(e)
+            span.set_status(SpanStatus(StatusCode.ERROR, str(e)))
             raise
 
         shared_attributes = {

packages/opentelemetry-instrumentation-pinecone/opentelemetry/instrumentation/pinecone/__init__.py

@@ -154,7 +154,12 @@ def _wrap(
             shared_attributes["server.address"] = instance._config.host
 
         start_time = time.time()
-        response = wrapped(*args, **kwargs)
+        try:
+            response = wrapped(*args, **kwargs)
+        except Exception as e:
+            span.record_exception(e)
+            span.set_status(Status(StatusCode.ERROR, str(e)))
+            raise
         end_time = time.time()
 
         duration = end_time - start_time

packages/opentelemetry-instrumentation-weaviate/opentelemetry/instrumentation/weaviate/wrapper.py

@@ -6,6 +6,7 @@
 from opentelemetry.instrumentation.utils import _SUPPRESS_INSTRUMENTATION_KEY
 from opentelemetry.instrumentation.weaviate.utils import dont_throw
 from opentelemetry.semconv.trace import SpanAttributes
+from opentelemetry.trace.status import Status, StatusCode
 
 
 logger = logging.getLogger(__name__)
@@ -46,7 +47,12 @@ def _wrap(tracer, to_wrap, wrapped, instance, args, kwargs):
         if instrumentor:
             instrumentor.instrument(to_wrap.get("method"), span, args, kwargs)
 
-        return_value = wrapped(*args, **kwargs)
+        try:
+            return_value = wrapped(*args, **kwargs)
+        except Exception as e:
+            span.record_exception(e)
+            span.set_status(Status(StatusCode.ERROR, str(e)))
+            raise
 
     return return_value