fix(ollama,together,replicate,sagemaker,bedrock): record exceptions on error spans

When API calls raise exceptions, spans were left in UNSET state with no
error information. Add span.record_exception() and set StatusCode.ERROR
on all sync/async wrappers in each affected package.

Fixes #412

Author: Koushik-Salammagari

packages/opentelemetry-instrumentation-bedrock/opentelemetry/instrumentation/bedrock/__init__.py

@@ -62,6 +62,7 @@
     Meters,
 )
 from opentelemetry.trace import Span, SpanKind, get_tracer
+from opentelemetry.trace.status import Status, StatusCode
 from wrapt import wrap_function_wrapper
 
 
@@ -220,7 +221,12 @@ def with_instrumentation(*args, **kwargs):
         with tracer.start_as_current_span(
             _span_name(operation_name, _model), kind=SpanKind.CLIENT, attributes=span_attributes
         ) as span:
-            response = fn(*args, **kwargs)
+            try:
+                response = fn(*args, **kwargs)
+            except Exception as e:
+                span.record_exception(e)
+                span.set_status(Status(StatusCode.ERROR, str(e)))
+                raise
             _handle_call(span, kwargs, response, metric_params, event_logger)
             return response
 
@@ -248,7 +254,13 @@ def with_instrumentation(*args, **kwargs):
             attributes=span_attributes,
         )
 
-        response = fn(*args, **kwargs)
+        try:
+            response = fn(*args, **kwargs)
+        except Exception as e:
+            span.record_exception(e)
+            span.set_status(Status(StatusCode.ERROR, str(e)))
+            span.end()
+            raise
         _handle_stream_call(span, kwargs, response, metric_params, event_logger)
 
         return response
@@ -276,7 +288,12 @@ def with_instrumentation(*args, **kwargs):
             kind=SpanKind.CLIENT,
             attributes=span_attributes,
         ) as span:
-            response = fn(*args, **kwargs)
+            try:
+                response = fn(*args, **kwargs)
+            except Exception as e:
+                span.record_exception(e)
+                span.set_status(Status(StatusCode.ERROR, str(e)))
+                raise
             _handle_converse(span, kwargs, response, metric_params, event_logger)
 
             return response
@@ -301,7 +318,13 @@ def with_instrumentation(*args, **kwargs):
             kind=SpanKind.CLIENT,
             attributes=span_attributes,
         )
-        response = fn(*args, **kwargs)
+        try:
+            response = fn(*args, **kwargs)
+        except Exception as e:
+            span.record_exception(e)
+            span.set_status(Status(StatusCode.ERROR, str(e)))
+            span.end()
+            raise
         if span.is_recording():
             _handle_converse_stream(span, kwargs, response, metric_params, event_logger)
 

packages/opentelemetry-instrumentation-ollama/opentelemetry/instrumentation/ollama/__init__.py

@@ -309,7 +309,13 @@ def _wrap(
     _handle_input(span, event_logger, llm_request_type, args, kwargs)
 
     start_time = time.perf_counter()
-    response = wrapped(*args, **kwargs)
+    try:
+        response = wrapped(*args, **kwargs)
+    except Exception as e:
+        span.record_exception(e)
+        span.set_status(Status(StatusCode.ERROR, str(e)))
+        span.end()
+        raise
     end_time = time.perf_counter()
 
     if response:
@@ -384,7 +390,13 @@ async def _awrap(
     _handle_input(span, event_logger, llm_request_type, args, kwargs)
 
     start_time = time.perf_counter()
-    response = await wrapped(*args, **kwargs)
+    try:
+        response = await wrapped(*args, **kwargs)
+    except Exception as e:
+        span.record_exception(e)
+        span.set_status(Status(StatusCode.ERROR, str(e)))
+        span.end()
+        raise
     end_time = time.perf_counter()
     if response:
         if duration_histogram:

packages/opentelemetry-instrumentation-replicate/opentelemetry/instrumentation/replicate/__init__.py

@@ -133,7 +133,13 @@ def _wrap(
 
     _handle_request(span, event_logger, args, kwargs)
 
-    response = wrapped(*args, **kwargs)
+    try:
+        response = wrapped(*args, **kwargs)
+    except Exception as e:
+        span.record_exception(e)
+        span.set_status(Status(StatusCode.ERROR, str(e)))
+        span.end()
+        raise
 
     if response:
         if is_streaming_response(response):

packages/opentelemetry-instrumentation-sagemaker/opentelemetry/instrumentation/sagemaker/__init__.py

@@ -31,6 +31,7 @@
     SUPPRESS_LANGUAGE_MODEL_INSTRUMENTATION_KEY,
 )
 from opentelemetry.trace import SpanKind, get_tracer
+from opentelemetry.trace.status import Status, StatusCode
 from wrapt import wrap_function_wrapper
 
 _instruments = ("boto3 >= 1.28.57",)
@@ -96,7 +97,12 @@ def with_instrumentation(*args, **kwargs):
         with tracer.start_as_current_span(
             "sagemaker.completion", kind=SpanKind.CLIENT
         ) as span:
-            response = fn(*args, **kwargs)
+            try:
+                response = fn(*args, **kwargs)
+            except Exception as e:
+                span.record_exception(e)
+                span.set_status(Status(StatusCode.ERROR, str(e)))
+                raise
             _handle_call(span, event_logger, kwargs, response)
 
             return response
@@ -112,7 +118,13 @@ def with_instrumentation(*args, **kwargs):
 
         span = tracer.start_span("sagemaker.completion", kind=SpanKind.CLIENT)
 
-        response = fn(*args, **kwargs)
+        try:
+            response = fn(*args, **kwargs)
+        except Exception as e:
+            span.record_exception(e)
+            span.set_status(Status(StatusCode.ERROR, str(e)))
+            span.end()
+            raise
 
         if span.is_recording():
             _handle_stream_call(span, event_logger, kwargs, response)

packages/opentelemetry-instrumentation-together/opentelemetry/instrumentation/together/__init__.py

@@ -122,7 +122,13 @@ def _wrap(
     )
     _handle_input(span, event_logger, llm_request_type, kwargs)
 
-    response = wrapped(*args, **kwargs)
+    try:
+        response = wrapped(*args, **kwargs)
+    except Exception as e:
+        span.record_exception(e)
+        span.set_status(Status(StatusCode.ERROR, str(e)))
+        span.end()
+        raise
 
     if response:
         _handle_response(span, event_logger, llm_request_type, response)