PR fixes

Author: lenatraceloop

packages/opentelemetry-instrumentation-groq/opentelemetry/instrumentation/groq/__init__.py

@@ -185,7 +185,7 @@ def _handle_streaming_response(span, accumulated_content, tool_calls, finish_rea
     if should_emit_events() and event_logger:
         emit_streaming_response_events(accumulated_content, finish_reason, event_logger, tool_calls=tool_calls)
     else:
-        set_streaming_response_attributes(span, accumulated_content, finish_reason, usage, tool_calls=tool_calls)
+        set_streaming_response_attributes(span, accumulated_content, finish_reason, tool_calls=tool_calls)
 
 
 def _create_stream_processor(response, span, event_logger):
@@ -201,9 +201,7 @@ def _create_stream_processor(response, span, event_logger):
             accumulated_content += content
         if tool_calls_delta:
             _accumulate_tool_calls(accumulated_tool_calls, tool_calls_delta)
-        for fr in chunk_finish_reasons:
-            if fr not in accumulated_finish_reasons:
-                accumulated_finish_reasons.append(fr)
+        accumulated_finish_reasons.extend(chunk_finish_reasons)
         if chunk_usage:
             usage = chunk_usage
         yield chunk
@@ -230,9 +228,7 @@ async def _create_async_stream_processor(response, span, event_logger):
             accumulated_content += content
         if tool_calls_delta:
             _accumulate_tool_calls(accumulated_tool_calls, tool_calls_delta)
-        for fr in chunk_finish_reasons:
-            if fr not in accumulated_finish_reasons:
-                accumulated_finish_reasons.append(fr)
+        accumulated_finish_reasons.extend(chunk_finish_reasons)
         if chunk_usage:
             usage = chunk_usage
         yield chunk

packages/opentelemetry-instrumentation-groq/opentelemetry/instrumentation/groq/event_emitter.py

@@ -54,7 +54,7 @@ def emit_choice_events(response: ChatCompletion, event_logger):
                     "content": choice.message.content,
                     "role": choice.message.role or "unknown",
                 },
-                finish_reason=_map_groq_finish_reason(choice.finish_reason) or "",
+                finish_reason=_map_groq_finish_reason(choice.finish_reason),
                 tool_calls=choice.message.tool_calls or None,
             ),
             event_logger=event_logger,

packages/opentelemetry-instrumentation-groq/opentelemetry/instrumentation/groq/span_utils.py

@@ -161,7 +161,7 @@ def set_model_input_attributes(span, kwargs):
                 pass
 
 
-def set_streaming_response_attributes(span, accumulated_content, finish_reason=None, usage=None, tool_calls=None):
+def set_streaming_response_attributes(span, accumulated_content, finish_reason=None, tool_calls=None):
     """Set gen_ai.output.messages span attribute for accumulated streaming response."""
     if not span.is_recording() or not should_send_prompts():
         return

packages/opentelemetry-instrumentation-groq/tests/traces/test_init.py

@@ -360,6 +360,21 @@ async def test_suppression_key_skips_span(self):
         assert result == "async_result"
         tracer.start_span.assert_not_called()
 
+    @pytest.mark.asyncio
+    async def test_otel_suppression_key_skips_span(self):
+        tracer = MagicMock()
+        wrapped = AsyncMock(return_value="async_result")
+        wrapper = _awrap(tracer, None, None, None, None, {})
+
+        token = context_api.attach(context_api.set_value(_SUPPRESS_INSTRUMENTATION_KEY, True))
+        try:
+            result = await wrapper(wrapped, None, [], {"model": "m"})
+        finally:
+            context_api.detach(token)
+
+        assert result == "async_result"
+        tracer.start_span.assert_not_called()
+
     @pytest.mark.asyncio
     async def test_api_exception_records_duration_and_reraises(self):
         tracer = MagicMock()