cai thien code docker

Author: TamCter

Dockerfile

@@ -1,44 +1,49 @@
 # ============================================================
-# Stage 1: deps — install production dependencies
+# Stage 1: base — base image with essential libraries
 # ============================================================
-FROM node:20-alpine AS deps
+FROM node:20-alpine AS base
 RUN apk add --no-cache libc6-compat
-
 WORKDIR /app
 
-COPY src/package.json src/package-lock.json ./
-RUN npm ci --omit=dev --ignore-scripts
+# Application version (passed at build time)
+ARG NEXT_PUBLIC_APP_VERSION
+ENV NEXT_PUBLIC_APP_VERSION=$NEXT_PUBLIC_APP_VERSION
 
 # ============================================================
-# Stage 2: builder — compile the Next.js app
+# Stage 2: development — prep for dev environment
 # ============================================================
-FROM node:20-alpine AS builder
+FROM base AS development
 
 WORKDIR /app
 
-# Copy ALL deps (including devDeps) for build
+# Copy ALL deps (including devDeps)
 COPY src/package.json src/package-lock.json ./
 RUN npm ci --ignore-scripts
 
 # Copy source code
 COPY src/ .
 
+# Disable Next.js telemetry
+ENV NEXT_TELEMETRY_DISABLED=1
+
+# ============================================================
+# Stage 3: builder — compile the Next.js app
+# ============================================================
+FROM development AS builder
+
 # Build-time env vars (public ones only — never leak secrets here)
 ARG NEXT_PUBLIC_SUPABASE_URL
 ARG NEXT_PUBLIC_SUPABASE_PUBLISHABLE_KEY
 
 ENV NEXT_PUBLIC_SUPABASE_URL=$NEXT_PUBLIC_SUPABASE_URL
 ENV NEXT_PUBLIC_SUPABASE_PUBLISHABLE_KEY=$NEXT_PUBLIC_SUPABASE_PUBLISHABLE_KEY
 
-# Disable Next.js telemetry
-ENV NEXT_TELEMETRY_DISABLED=1
-
 RUN npm run build
 
 # ============================================================
 # Stage 3: runner — minimal production image
 # ============================================================
-FROM node:20-alpine AS runner
+FROM base AS runner
 
 WORKDIR /app
 
@@ -50,7 +55,7 @@ RUN addgroup --system --gid 1001 nodejs && \
     adduser  --system --uid 1001 nextjs
 
 # Copy built assets from builder
-COPY --from=builder /app/public          ./public
+COPY --from=builder --chown=nextjs:nodejs /app/public ./public
 COPY --from=builder --chown=nextjs:nodejs /app/.next/standalone ./
 COPY --from=builder --chown=nextjs:nodejs /app/.next/static     ./.next/static
 

docker-compose.yml

@@ -8,10 +8,11 @@ services:
     build:
       context: .
       dockerfile: Dockerfile
-      target: builder          # build xong là chạy ngay, không cần stage runner
+      target: development      # build xong là chạy ngay (npm install), không cần build sản phẩm
       args:
         NEXT_PUBLIC_SUPABASE_URL: ${NEXT_PUBLIC_SUPABASE_URL}
         NEXT_PUBLIC_SUPABASE_PUBLISHABLE_KEY: ${NEXT_PUBLIC_SUPABASE_PUBLISHABLE_KEY}
+        NEXT_PUBLIC_APP_VERSION: ${APP_VERSION:-0.1.0}
     command: npm run dev
     ports:
       - "3000:3000"
@@ -23,6 +24,7 @@ services:
       - NODE_ENV=development
       - NEXT_PUBLIC_SUPABASE_URL=${NEXT_PUBLIC_SUPABASE_URL}
       - NEXT_PUBLIC_SUPABASE_PUBLISHABLE_KEY=${NEXT_PUBLIC_SUPABASE_PUBLISHABLE_KEY}
+      - NEXT_PUBLIC_APP_VERSION=${APP_VERSION:-0.1.0}
       - SUPABASE_SERVICE_ROLE_KEY=${SUPABASE_SERVICE_ROLE_KEY}
     env_file:
       - src/.env.local
@@ -43,9 +45,11 @@ services:
       args:
         NEXT_PUBLIC_SUPABASE_URL: ${NEXT_PUBLIC_SUPABASE_URL}
         NEXT_PUBLIC_SUPABASE_PUBLISHABLE_KEY: ${NEXT_PUBLIC_SUPABASE_PUBLISHABLE_KEY}
+        NEXT_PUBLIC_APP_VERSION: ${APP_VERSION:-0.1.0}
     ports:
       - "3000:3000"
     environment:
+      - NEXT_PUBLIC_APP_VERSION=${APP_VERSION:-0.1.0}
       - SUPABASE_SERVICE_ROLE_KEY=${SUPABASE_SERVICE_ROLE_KEY}
     env_file:
       - src/.env.local

src/app/api/health/route.ts

@@ -10,7 +10,7 @@ export async function GET() {
       status: "ok",
       timestamp: new Date().toISOString(),
       uptime: process.uptime(),
-      version: process.env.npm_package_version ?? "unknown",
+      version: process.env.NEXT_PUBLIC_APP_VERSION ?? "unknown",
       environment: process.env.NODE_ENV,
     },
     { status: 200 }