ShiftEnter is now an instance property to avoid global static states

Author: radare

src/compose_bar.vala

@@ -8,7 +8,7 @@ namespace Dc {
 
         /* When false (default), Return sends and Shift+Return inserts a
            newline. When true, the roles are swapped. */
-        public static bool shift_enter_sends = false;
+        public bool shift_enter_sends { get; set; default = false; }
 
         public signal void send_message (string text, string? file_path, string? file_name, int quote_msg_id);
         public signal void edit_message (int msg_id, string new_text);

src/settings_dialog.vala

@@ -23,7 +23,6 @@ namespace Dc {
             markdown_rendering = kf_bool (kf, "markdown_rendering", false);
             Markdown.enabled = markdown_rendering;
             shift_enter_sends = kf_bool (kf, "shift_enter_sends", false);
-            ComposeBar.shift_enter_sends = shift_enter_sends;
             notifications_enabled = kf_bool (kf, "notifications_enabled", true);
         }
 
@@ -46,7 +45,7 @@ namespace Dc {
         }
 
         public void save_shift_enter_sends (bool v) {
-            shift_enter_sends = v; ComposeBar.shift_enter_sends = v;
+            shift_enter_sends = v;
             save_to_file ((kf) => { kf.set_boolean ("General", "shift_enter_sends", v); });
         }
 

src/window.vala

@@ -311,6 +311,8 @@ namespace Dc {
             msg_box.append (scroll_overlay);
 
             compose_bar = new ComposeBar ();
+            settings.bind_property ("shift-enter-sends", compose_bar,
+                                    "shift-enter-sends", BindingFlags.SYNC_CREATE);
             compose_bar.send_message.connect (on_send_message);
             compose_bar.edit_message.connect ((msg_id, new_text) => {
                 if (msg_actions != null)