Skip to content

Commit 87e6d2a

Browse files
committed
Update message properties in-place instead of remove+insert
1 parent 3a99c75 commit 87e6d2a

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

src/message_actions.vala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -192,8 +192,8 @@ namespace Dc {
192192
var msg = RpcClient.parse_message (msg_obj, rpc.self_email);
193193
int idx = find_message_index (message_store, msg_id);
194194
if (idx >= 0) {
195-
message_store.remove (idx);
196-
message_store.insert (idx, msg);
195+
Object[] replacements = { msg };
196+
message_store.splice (idx, 1, replacements);
197197
}
198198
} catch (Error e) {
199199
/* Reaction will appear on next message reload */

src/pinned_messages_manager.vala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -188,8 +188,8 @@ namespace Dc {
188188
int idx = find_message_index (message_store, msg_id);
189189
if (idx < 0) return;
190190
var m = (Message) message_store.get_item (idx);
191-
message_store.remove (idx);
192-
message_store.insert (idx, m);
191+
Object[] replacements = { m };
192+
message_store.splice (idx, 1, replacements);
193193
}
194194
}
195195
}

0 commit comments

Comments
 (0)