Skip to content

Commit 062fdfd

Browse files
gabrittogabritto
committed
don't use text change's create new file for existing empty file
1 parent d210074 commit 062fdfd

10 files changed

Lines changed: 106 additions & 19 deletions

File tree

‎src/harness/client.ts‎

Lines changed: 32 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import { GetApplicableRefactorsRequestArgs, GetEditsForRefactorRequestArgs } from "../server/protocol.js";
12
import {
23
ApplicableRefactorInfo,
34
CallHierarchyIncomingCall,
@@ -36,6 +37,7 @@ import {
3637
ImplementationLocation,
3738
InlayHint,
3839
InlayHintKind,
40+
InteractiveRefactorArguments,
3941
isString,
4042
JSDocTagInfo,
4143
LanguageService,
@@ -52,6 +54,7 @@ import {
5254
Program,
5355
QuickInfo,
5456
RefactorEditInfo,
57+
RefactorTriggerReason,
5558
ReferencedSymbol,
5659
ReferenceEntry,
5760
RenameInfo,
@@ -787,11 +790,25 @@ export class SessionClient implements LanguageService {
787790
return { file, line, offset, endLine, endOffset };
788791
}
789792

790-
getApplicableRefactors(fileName: string, positionOrRange: number | TextRange): ApplicableRefactorInfo[] {
791-
const args = this.createFileLocationOrRangeRequestArgs(positionOrRange, fileName);
792-
793+
getApplicableRefactors(
794+
fileName: string,
795+
positionOrRange: number | TextRange,
796+
preferences: UserPreferences | undefined,
797+
triggerReason?: RefactorTriggerReason,
798+
kind?: string,
799+
includeInteractiveActions?: boolean): ApplicableRefactorInfo[] {
800+
if (preferences) { // Temporarily set preferences
801+
this.configure(preferences);
802+
}
803+
const args: GetApplicableRefactorsRequestArgs = this.createFileLocationOrRangeRequestArgs(positionOrRange, fileName);
804+
args.triggerReason = triggerReason;
805+
args.kind = kind;
806+
args.includeInteractiveActions = includeInteractiveActions;
793807
const request = this.processRequest<protocol.GetApplicableRefactorsRequest>(protocol.CommandTypes.GetApplicableRefactors, args);
794808
const response = this.processResponse<protocol.GetApplicableRefactorsResponse>(request);
809+
if (preferences) { // Restore preferences
810+
this.configure(this.preferences || {});
811+
}
795812
return response.body!; // TODO: GH#18217
796813
}
797814

@@ -808,11 +825,16 @@ export class SessionClient implements LanguageService {
808825
_formatOptions: FormatCodeSettings,
809826
positionOrRange: number | TextRange,
810827
refactorName: string,
811-
actionName: string): RefactorEditInfo {
812-
813-
const args = this.createFileLocationOrRangeRequestArgs(positionOrRange, fileName) as protocol.GetEditsForRefactorRequestArgs;
828+
actionName: string,
829+
preferences: UserPreferences | undefined,
830+
interactiveRefactorArguments?: InteractiveRefactorArguments): RefactorEditInfo { // >> Update here
831+
if (preferences) { // Temporarily set preferences
832+
this.configure(preferences);
833+
}
834+
const args: GetEditsForRefactorRequestArgs = this.createFileLocationOrRangeRequestArgs(positionOrRange, fileName) as protocol.GetEditsForRefactorRequestArgs;
814835
args.refactor = refactorName;
815836
args.action = actionName;
837+
args.interactiveRefactorArguments = interactiveRefactorArguments;
816838

817839
const request = this.processRequest<protocol.GetEditsForRefactorRequest>(protocol.CommandTypes.GetEditsForRefactor, args);
818840
const response = this.processResponse<protocol.GetEditsForRefactorResponse>(request);
@@ -829,6 +851,10 @@ export class SessionClient implements LanguageService {
829851
renameLocation = this.lineOffsetToPosition(renameFilename, response.body.renameLocation!);
830852
}
831853

854+
if (preferences) { // Restore preferences
855+
this.configure(this.preferences || {});
856+
}
857+
832858
return {
833859
edits,
834860
renameFilename,

‎src/services/refactors/moveToFile.ts‎

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,7 @@ function doChange(context: RefactorContext, oldFile: SourceFile, targetFile: str
177177
const checker = program.getTypeChecker();
178178
const usage = getUsageInfo(oldFile, toMove.all, checker);
179179
//For a new file or an existing blank target file
180-
if (!host.fileExists(targetFile) || host.fileExists(targetFile) && program.getSourceFile(targetFile)?.statements.length === 0) {
180+
if (!host.fileExists(targetFile)) {
181181
changes.createNewFile(oldFile, targetFile, getNewStatementsAndRemoveFromOldFile(oldFile, targetFile, usage, changes, toMove, program, host, preferences));
182182
addNewFileToTsconfig(program, changes, oldFile.fileName, targetFile, hostGetCanonicalFileName(host));
183183
}
@@ -189,7 +189,15 @@ function doChange(context: RefactorContext, oldFile: SourceFile, targetFile: str
189189
}
190190

191191
function getNewStatementsAndRemoveFromOldFile(
192-
oldFile: SourceFile, targetFile: string | SourceFile, usage: UsageInfo, changes: textChanges.ChangeTracker, toMove: ToMove, program: Program, host: LanguageServiceHost, preferences: UserPreferences, importAdder?: codefix.ImportAdder
192+
oldFile: SourceFile,
193+
targetFile: string | SourceFile,
194+
usage: UsageInfo,
195+
changes: textChanges.ChangeTracker,
196+
toMove: ToMove,
197+
program: Program,
198+
host: LanguageServiceHost,
199+
preferences: UserPreferences,
200+
importAdder?: codefix.ImportAdder
193201
) {
194202
const checker = program.getTypeChecker();
195203
const prologueDirectives = takeWhile(oldFile.statements, isPrologueDirective);
@@ -218,6 +226,9 @@ function getNewStatementsAndRemoveFromOldFile(
218226
if (targetFile.statements.length > 0) {
219227
changes.insertNodesAfter(targetFile, targetFile.statements[targetFile.statements.length - 1], body);
220228
}
229+
else {
230+
changes.insertNodesAtEndOfFile(targetFile, body, /*blankLineBetween*/ false);
231+
}
221232
if (imports.length > 0) {
222233
insertImports(changes, targetFile, imports, /*blankLineBetween*/ true, preferences);
223234
}

‎src/services/textChanges.ts‎

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -631,6 +631,25 @@ export class ChangeTracker {
631631
}
632632
}
633633

634+
public insertNodesAtEndOfFile(
635+
sourceFile: SourceFile,
636+
newNodes: readonly Statement[],
637+
blankLineBetween: boolean): void {
638+
this.insertAtEndOfFile(sourceFile, newNodes, blankLineBetween);
639+
}
640+
641+
private insertAtEndOfFile(
642+
sourceFile: SourceFile,
643+
insert: readonly Statement[],
644+
blankLineBetween: boolean): void {
645+
const pos = sourceFile.end + 1;
646+
const options = {
647+
prefix: this.newLineCharacter,
648+
suffix: blankLineBetween ? this.newLineCharacter : "",
649+
};
650+
this.insertNodesAt(sourceFile, pos, insert, options);
651+
}
652+
634653
private insertStatementsInNewFile(fileName: string, statements: readonly (Statement | SyntaxKind.NewLineTrivia)[], oldFile?: SourceFile): void {
635654
if (!this.newFileChanges) {
636655
this.newFileChanges = createMultiMap<string, NewFileInsertion>();

‎src/services/tsconfig.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,5 +6,5 @@
66
{ "path": "../compiler" },
77
{ "path": "../jsTyping" }
88
],
9-
"include": ["**/*"]
9+
"include": ["**/*", "refactors/moveToFile.ts"]
1010
}

‎src/services/types.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -652,7 +652,7 @@ export interface LanguageService {
652652
* arguments for any interactive action before offering it.
653653
*/
654654
getApplicableRefactors(fileName: string, positionOrRange: number | TextRange, preferences: UserPreferences | undefined, triggerReason?: RefactorTriggerReason, kind?: string, includeInteractiveActions?: boolean): ApplicableRefactorInfo[];
655-
getEditsForRefactor(fileName: string, formatOptions: FormatCodeSettings, positionOrRange: number | TextRange, refactorName: string, actionName: string, preferences: UserPreferences | undefined, includeInteractiveActions?: InteractiveRefactorArguments): RefactorEditInfo | undefined;
655+
getEditsForRefactor(fileName: string, formatOptions: FormatCodeSettings, positionOrRange: number | TextRange, refactorName: string, actionName: string, preferences: UserPreferences | undefined, interactiveRefactorArguments?: InteractiveRefactorArguments): RefactorEditInfo | undefined;
656656
getMoveToRefactoringFileSuggestions(fileName: string, positionOrRange: number | TextRange, preferences: UserPreferences | undefined, triggerReason?: RefactorTriggerReason, kind?: string): { newFileName: string, files: string[] };
657657
organizeImports(args: OrganizeImportsArgs, formatOptions: FormatCodeSettings, preferences: UserPreferences | undefined): readonly FileTextChanges[];
658658
getEditsForFileRename(oldFilePath: string, newFilePath: string, formatOptions: FormatCodeSettings, preferences: UserPreferences | undefined): readonly FileTextChanges[];

‎tests/baselines/reference/api/tsserverlibrary.d.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10196,7 +10196,7 @@ declare namespace ts {
1019610196
* arguments for any interactive action before offering it.
1019710197
*/
1019810198
getApplicableRefactors(fileName: string, positionOrRange: number | TextRange, preferences: UserPreferences | undefined, triggerReason?: RefactorTriggerReason, kind?: string, includeInteractiveActions?: boolean): ApplicableRefactorInfo[];
10199-
getEditsForRefactor(fileName: string, formatOptions: FormatCodeSettings, positionOrRange: number | TextRange, refactorName: string, actionName: string, preferences: UserPreferences | undefined, includeInteractiveActions?: InteractiveRefactorArguments): RefactorEditInfo | undefined;
10199+
getEditsForRefactor(fileName: string, formatOptions: FormatCodeSettings, positionOrRange: number | TextRange, refactorName: string, actionName: string, preferences: UserPreferences | undefined, interactiveRefactorArguments?: InteractiveRefactorArguments): RefactorEditInfo | undefined;
1020010200
getMoveToRefactoringFileSuggestions(fileName: string, positionOrRange: number | TextRange, preferences: UserPreferences | undefined, triggerReason?: RefactorTriggerReason, kind?: string): {
1020110201
newFileName: string;
1020210202
files: string[];

‎tests/baselines/reference/api/typescript.d.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6227,7 +6227,7 @@ declare namespace ts {
62276227
* arguments for any interactive action before offering it.
62286228
*/
62296229
getApplicableRefactors(fileName: string, positionOrRange: number | TextRange, preferences: UserPreferences | undefined, triggerReason?: RefactorTriggerReason, kind?: string, includeInteractiveActions?: boolean): ApplicableRefactorInfo[];
6230-
getEditsForRefactor(fileName: string, formatOptions: FormatCodeSettings, positionOrRange: number | TextRange, refactorName: string, actionName: string, preferences: UserPreferences | undefined, includeInteractiveActions?: InteractiveRefactorArguments): RefactorEditInfo | undefined;
6230+
getEditsForRefactor(fileName: string, formatOptions: FormatCodeSettings, positionOrRange: number | TextRange, refactorName: string, actionName: string, preferences: UserPreferences | undefined, interactiveRefactorArguments?: InteractiveRefactorArguments): RefactorEditInfo | undefined;
62316231
getMoveToRefactoringFileSuggestions(fileName: string, positionOrRange: number | TextRange, preferences: UserPreferences | undefined, triggerReason?: RefactorTriggerReason, kind?: string): {
62326232
newFileName: string;
62336233
files: string[];

‎tests/cases/fourslash/moveToFile_blankExistingFile.ts‎

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,14 @@ verify.moveToFile({
1818
`,
1919

2020
"/bar.ts":
21-
`import { b } from './other';
21+
`//
2222
import { p } from './a';
2323
24-
const y: Date = p + b;
25-
`,
24+
25+
import { b } from "./other";
26+
27+
28+
const y: Date = p + b;`,
2629
},
2730
interactiveRefactorArguments: {targetFile: "/bar.ts"},
2831
});

‎tests/cases/fourslash/moveToFile_differentDirectories2.ts‎

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,12 @@ export const a = 10;
2323
y;`,
2424

2525
"/src/dir2/bar.ts":
26-
`import { b } from '../dir1/other';
27-
import { a } from '../dir1/a';
26+
`import { a } from '../dir1/a';
2827
29-
export const y = b + a;
30-
`,
28+
import { b } from "../dir1/other";
29+
30+
31+
export const y = b + a;`,
3132
},
3233
interactiveRefactorArguments: { targetFile: "/src/dir2/bar.ts" }
3334
});

‎tests/cases/fourslash/server/moveToFile_emptyTargetFile.ts‎

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
/// <reference path='../fourslash.ts' />
2+
3+
// @Filename: /source.ts
4+
////[|export const a = 1;|]
5+
////const b = 2;
6+
////console.log(a, b);
7+
8+
// @Filename: /target.ts
9+
/////** empty */
10+
11+
// @Filename: /tsconfig.json
12+
///// { "compilerOptions": { "newLine": "lf" } }
13+
14+
verify.moveToFile({
15+
newFileContents: {
16+
"/source.ts":
17+
`import { a } from "./target";
18+
19+
const b = 2;
20+
console.log(a, b);`,
21+
"/target.ts":
22+
`/** empty */
23+
export const a = 1;
24+
`,
25+
},
26+
interactiveRefactorArguments: { targetFile: "/target.ts" },
27+
});

0 commit comments

Comments
 (0)
⚡