Commit f873ed6
committed
docs(openapi): correct converter comment about runtime SSRF coverage
Earlier comment claimed the runtime ``ensure_secure_url`` in
``call_tool`` "already blocks the request" for loopback-redirect SSRF.
That is wrong. ``ensure_secure_url`` allows ``http://`` to literal
loopback hosts as a legitimate localhost-dev case, so a remote spec
declaring ``servers[0].url = http://127.0.0.1:9090`` slips through the
runtime gate and reaches the loopback service.
Reword the comment to make the actual coverage split explicit: the
runtime check catches non-loopback internal addresses (cloud metadata,
RFC1918 ranges); the conversion-time check is the *only* defense for
the attacker-controlled-loopback case because the spec's origin is the
sole signal that distinguishes it from a legitimate localhost call,
and that information only exists at conversion time.
No behavior change.1 parent 3a50250 commit f873ed6
1 file changed
Lines changed: 3 additions & 11 deletions
Lines changed: 3 additions & 11 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
155 | 155 | | |
156 | 156 | | |
157 | 157 | | |
158 | | - | |
159 | | - | |
160 | | - | |
161 | | - | |
162 | | - | |
163 | | - | |
164 | | - | |
165 | | - | |
166 | | - | |
167 | | - | |
168 | | - | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
169 | 161 | | |
170 | 162 | | |
171 | 163 | | |
| |||
0 commit comments