Skip snapshot tests when snapshots are disabled

gahaas · gahaas · commit 39e5f2838723 · 2026-03-24T11:32:55.000+01:00
These tests create node snapshots even when node snapshots are disabled.
Node snapshots don't work at the moment because FunctionTemplateInfo
objects with fast API callbacks are put into the snapshot, but this
causes security issues.
diff --git a/test/common/index.js b/test/common/index.js
@@ -68,6 +68,7 @@ const hasCrypto = Boolean(process.versions.openssl) &&
                   !process.env.NODE_SKIP_CRYPTO;
 
 const hasInspector = Boolean(process.features.inspector);
+const hasSnapshot = Boolean(process.features.node_use_node_snapshot);
 const hasSQLite = Boolean(process.versions.sqlite);
 
 const hasQuic = hasCrypto && !!process.features.quic;
@@ -743,6 +744,13 @@ function skipIfInspectorDisabled() {
   }
 }
 
+function skipIfSnapshotDisabled() {
+  console.log("Snapshot: ", hasSnapshot);
+  if (!hasSnapshot) {
+    skip('Node snapshot is disabled');
+  }
+}
+
 function skipIf32Bits() {
   if (bits < 64) {
     skip('The tested feature is not available in 32bit builds');
@@ -972,6 +980,7 @@ const common = {
   hasCrypto,
   hasQuic,
   hasInspector,
+  hasSnapshot,
   hasSQLite,
   invalidArgTypeHelper,
   isAlive,
@@ -1003,6 +1012,7 @@ const common = {
   skipIf32Bits,
   skipIfEslintMissing,
   skipIfInspectorDisabled,
+  skipIfSnapshotDisabled,
   skipIfSQLiteMissing,
   spawnPromisified,
   sleepSync,
diff --git a/test/common/snapshot.js b/test/common/snapshot.js
@@ -1,5 +1,8 @@
 'use strict';
 
+const common = require('../common');
+common.skipIfSnapshotDisabled();
+
 const tmpdir = require('../common/tmpdir');
 const { spawnSync } = require('child_process');
 const fs = require('fs');
diff --git a/test/parallel/test-inspect-address-in-use.js b/test/parallel/test-inspect-address-in-use.js
@@ -1,6 +1,7 @@
 'use strict';
 const common = require('../common');
 common.skipIfInspectorDisabled();
+common.skipIfSnapshotDisabled();
 
 const { spawnSync } = require('child_process');
 const { createServer } = require('http');
diff --git a/test/parallel/test-snapshot-api.js b/test/parallel/test-snapshot-api.js
@@ -2,7 +2,8 @@
 
 // This tests snapshot JS API using the example in the docs.
 
-require('../common');
+const common = require('../common');
+common.skipIfSnapshotDisabled();
 const assert = require('assert');
 const tmpdir = require('../common/tmpdir');
 const fixtures = require('../common/fixtures');
diff --git a/test/parallel/test-snapshot-argv1.js b/test/parallel/test-snapshot-argv1.js
@@ -2,7 +2,9 @@
 
 // This tests snapshot JS API using the example in the docs.
 
-require('../common');
+const common = require('../common');
+common.skipIfSnapshotDisabled();
+
 const assert = require('assert');
 const { spawnSync } = require('child_process');
 const tmpdir = require('../common/tmpdir');
diff --git a/test/parallel/test-snapshot-basic.js b/test/parallel/test-snapshot-basic.js
@@ -3,7 +3,8 @@
 // This tests that user land snapshots works when the instance restored from
 // the snapshot is launched with --help, --check
 
-require('../common');
+const common = require('../common');
+common.skipIfSnapshotDisabled();
 const assert = require('assert');
 const tmpdir = require('../common/tmpdir');
 const fixtures = require('../common/fixtures');
diff --git a/test/parallel/test-snapshot-child-process-sync.js b/test/parallel/test-snapshot-child-process-sync.js
@@ -3,7 +3,8 @@
 // This tests that process.cwd() is accurate when
 // restoring state from a snapshot
 
-const { isInsideDirWithUnusualChars } = require('../common');
+const { isInsideDirWithUnusualChars, skipIfSnapshotDisabled } = require('../common');
+skipIfSnapshotDisabled();
 const { spawnSyncAndAssert } = require('../common/child_process');
 const tmpdir = require('../common/tmpdir');
 const fixtures = require('../common/fixtures');
diff --git a/test/parallel/test-snapshot-cjs-main.js b/test/parallel/test-snapshot-cjs-main.js
@@ -3,7 +3,8 @@
 // This tests that user land snapshots works when the instance restored from
 // the snapshot is launched as a CJS module.
 
-require('../common');
+const common = require('../common');
+common.skipIfSnapshotDisabled();
 const assert = require('assert');
 const { spawnSync } = require('child_process');
 const tmpdir = require('../common/tmpdir');
diff --git a/test/parallel/test-snapshot-config.js b/test/parallel/test-snapshot-config.js
@@ -2,7 +2,9 @@
 
 // This tests --build-snapshot-config.
 
-require('../common');
+const common = require('../common');
+common.skipIfSnapshotDisabled();
+
 const assert = require('assert');
 const {
   spawnSyncAndAssert,
diff --git a/test/parallel/test-snapshot-console.js b/test/parallel/test-snapshot-console.js
@@ -4,6 +4,7 @@
 
 const common = require('../common');
 common.skipIfInspectorDisabled();
+common.skipIfSnapshotDisabled();
 
 const assert = require('assert');
 const { spawnSync } = require('child_process');
diff --git a/test/parallel/test-snapshot-coverage.js b/test/parallel/test-snapshot-coverage.js
@@ -4,6 +4,7 @@
 
 const common = require('../common');
 common.skipIfInspectorDisabled();
+common.skipIfSnapshotDisabled();
 
 const { spawnSyncAndExitWithoutError } = require('../common/child_process');
 const tmpdir = require('../common/tmpdir');
diff --git a/test/parallel/test-snapshot-cwd.js b/test/parallel/test-snapshot-cwd.js
@@ -3,7 +3,9 @@
 // This tests that process.cwd() is accurate when
 // restoring state from a snapshot
 
-require('../common');
+const common = require('../common');
+common.skipIfSnapshotDisabled();
+
 const { spawnSyncAndAssert } = require('../common/child_process');
 const tmpdir = require('../common/tmpdir');
 const fixtures = require('../common/fixtures');
diff --git a/test/parallel/test-snapshot-error.js b/test/parallel/test-snapshot-error.js
@@ -3,7 +3,8 @@
 // This tests that the errors in the snapshot script can be handled
 // properly.
 
-require('../common');
+const common = require('../common');
+common.skipIfSnapshotDisabled();
 const assert = require('assert');
 const { spawnSync } = require('child_process');
 const tmpdir = require('../common/tmpdir');
diff --git a/test/parallel/test-snapshot-eval.js b/test/parallel/test-snapshot-eval.js
@@ -3,7 +3,8 @@
 // This tests that user land snapshots works when the instance restored from
 // the snapshot is launched with -p and -e
 
-require('../common');
+const common = require('../common');
+common.skipIfSnapshotDisabled();
 const assert = require('assert');
 const { spawnSync } = require('child_process');
 const tmpdir = require('../common/tmpdir');
diff --git a/test/parallel/test-snapshot-gzip.js b/test/parallel/test-snapshot-gzip.js
@@ -3,7 +3,8 @@
 // This tests that a program that decompresses a gzip file and saves the
 // content can be snapshotted and deserialized properly.
 
-require('../common');
+const common = require('../common');
+common.skipIfSnapshotDisabled();
 const assert = require('assert');
 const { spawnSync } = require('child_process');
 const tmpdir = require('../common/tmpdir');
diff --git a/test/parallel/test-snapshot-incompatible.js b/test/parallel/test-snapshot-incompatible.js
@@ -3,7 +3,8 @@
 // This tests that Node.js refuses to load snapshots built with incompatible
 // V8 configurations.
 
-require('../common');
+const common = require('../common');
+common.skipIfSnapshotDisabled();
 const assert = require('assert');
 const { spawnSync } = require('child_process');
 const tmpdir = require('../common/tmpdir');
diff --git a/test/parallel/test-snapshot-namespaced-builtin.js b/test/parallel/test-snapshot-namespaced-builtin.js
@@ -2,7 +2,9 @@
 
 // This tests snapshot JS API using the example in the docs.
 
-require('../common');
+const common = require('../common');
+common.skipIfSnapshotDisabled();
+
 const assert = require('assert');
 const { spawnSync } = require('child_process');
 const tmpdir = require('../common/tmpdir');
diff --git a/test/parallel/test-snapshot-net.js b/test/parallel/test-snapshot-net.js
@@ -3,7 +3,8 @@
 // This tests that a local TCP server can be snapshotted and the
 // diagnostics channels work across serialization.
 
-require('../common');
+const common = require('../common');
+common.skipIfSnapshotDisabled();
 const assert = require('assert');
 const { spawnSync } = require('child_process');
 const tmpdir = require('../common/tmpdir');
diff --git a/test/parallel/test-snapshot-reproducible.js b/test/parallel/test-snapshot-reproducible.js
@@ -1,6 +1,7 @@
 'use strict';
 
-require('../common');
+const common = require('../common');
+common.skipIfSnapshotDisabled();
 const { spawnSyncAndAssert } = require('../common/child_process');
 const tmpdir = require('../common/tmpdir');
 const fs = require('fs');
diff --git a/test/parallel/test-snapshot-stack-trace-limit-mutation.js b/test/parallel/test-snapshot-stack-trace-limit-mutation.js
@@ -3,7 +3,8 @@
 // This tests mutation to Error.stackTraceLimit in both the snapshot builder script
 // and the snapshot main script work.
 
-require('../common');
+const common = require('../common');
+common.skipIfSnapshotDisabled();
 const assert = require('assert');
 const tmpdir = require('../common/tmpdir');
 const fixtures = require('../common/fixtures');
diff --git a/test/parallel/test-snapshot-stack-trace-limit.js b/test/parallel/test-snapshot-stack-trace-limit.js
@@ -3,7 +3,8 @@
 // This tests Error.stackTraceLimit is fixed up for snapshot-building contexts,
 // and can be restored after deserialization.
 
-require('../common');
+const common = require('../common');
+common.skipIfSnapshotDisabled();
 const assert = require('assert');
 const tmpdir = require('../common/tmpdir');
 const fixtures = require('../common/fixtures');
diff --git a/test/parallel/test-snapshot-typescript.js b/test/parallel/test-snapshot-typescript.js
@@ -2,7 +2,8 @@
 
 // This tests the TypeScript compiler in the snapshot.
 
-require('../common');
+const common = require('../common');
+common.skipIfSnapshotDisabled();
 
 const assert = require('assert');
 const { spawnSync } = require('child_process');
diff --git a/test/parallel/test-snapshot-umd.js b/test/parallel/test-snapshot-umd.js
@@ -2,7 +2,8 @@
 
 // This tests the behavior of loading a UMD module with --build-snapshot
 
-require('../common');
+const common = require('../common');
+common.skipIfSnapshotDisabled();
 const assert = require('assert');
 const { spawnSync } = require('child_process');
 const tmpdir = require('../common/tmpdir');
diff --git a/test/parallel/test-snapshot-warning.js b/test/parallel/test-snapshot-warning.js
@@ -4,7 +4,8 @@
 // during snapshot serialization and installed again during
 // deserialization.
 
-require('../common');
+const common = require('../common');
+common.skipIfSnapshotDisabled();
 
 const assert = require('assert');
 const tmpdir = require('../common/tmpdir');
diff --git a/test/parallel/test-snapshot-weak-reference.js b/test/parallel/test-snapshot-weak-reference.js
@@ -2,7 +2,9 @@
 
 // This tests that weak references work across serialization.
 
-require('../common');
+const common = require('../common');
+common.skipIfSnapshotDisabled();
+
 const assert = require('assert');
 const { spawnSync } = require('child_process');
 const tmpdir = require('../common/tmpdir');
diff --git a/test/parallel/test-snapshot-worker.js b/test/parallel/test-snapshot-worker.js
@@ -2,7 +2,8 @@
 
 // This tests snapshot JS API using the example in the docs.
 
-require('../common');
+const common = require('../common');
+common.skipIfSnapshotDisabled();
 const assert = require('assert');
 const { spawnSync } = require('child_process');
 const tmpdir = require('../common/tmpdir');
