Upgrade to angular 2.0.0-rc.1#176
Conversation
|
@valorkin sorry to bother you again! I've updated this one as well to rc.1 and made Travis happy-green. Could you please take a look whenever you have the chance? Good luck at ngconf! |
|
@heidermatos I think it needs a bit more testing, but it looks OK to me so far. |
|
@ciriarte you can bother me with such PR's as much as you can :) |
| @@ -1,3 +1,5 @@ | |||
| /// <reference path="node_modules/@angular/platform-browser/index.d.ts" /> | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
looks good, with some comments :) |
|
@valorkin Thanks for the feedback! I've applied the changes you've requested. My only concern is the following npm warning that appears due to the shift to dev dep of rxjs:
I guess we should leave it to the user to declare those dependencies in their project.json, according to this commit: Therefore, I've decided to just instruct Travis to install rxjs during build time. |
| 'reflect-metadata', | ||
| 'angular2/common', | ||
| 'angular2/core' | ||
| '@angular/common', |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
@valorkin done 👍 it did speed up the build a lot! I've removed 4 as well. Thanks for your feedback, I'm learning a lot. |
|
very good man, I thank the commitment of all to finalize these modifications! |
|
Hey, guys I am flying back, tomorrow I should be able to test and merge On Sun, May 8, 2016, 17:04 Rodolfo Galli notifications@github.com wrote:
|
|
No problem, i'll be waiting and if you need to be here to help! |
Hi Guys,
I've updated the code to point to 2.0.0-rc.1, please let me know if it looks OK or you want me to change anything.