Adding checkboxes by TKul6 · Pull Request #181 · valor-software/ng2-tree

TKul6 · 2017-11-25T10:24:58Z

Hi,

I almost completed the checkboxes feature and I wanted your opinion (to see if there any necessary changes I should do.)

I'm still experiencing some difficulties with implementing the Indeterminated state of a checkbox. However I wanted to start the merge process to see that everything else is fine.

As soon as you give me the O.K. I will add tests and documentation.

Thanks,
TMaster.

codecov · 2017-11-25T10:46:26Z

Codecov Report

Merging #181 into develop will decrease coverage by 5.52%.
The diff coverage is 43.75%.

@@             Coverage Diff             @@
##           develop     #181      +/-   ##
===========================================
- Coverage    95.86%   90.34%   -5.53%     
===========================================
  Files           23       23              
  Lines          823      911      +88     
  Branches       120      130      +10     
===========================================
+ Hits           789      823      +34     
- Misses          16       70      +54     
  Partials        18       18

Impacted Files	Coverage Δ
src/tree.types.ts	`100% <ø> (ø)`	⬆️
src/tree.ts	`93.11% <ø> (ø)`	⬆️
src/tree.component.ts	`90.9% <100%> (+0.71%)`	⬆️
src/tree-internal.component.ts	`70.16% <31.34%> (-23.12%)`	⬇️
src/tree-controller.ts	`96.22% <50%> (-3.78%)`	⬇️
src/tree.service.ts	`96% <66.66%> (-4%)`	⬇️
src/tree.events.ts	`84.78% <66.66%> (-4.41%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0aab34...f62e3b5. Read the comment docs.

rychkog · 2017-11-25T11:16:39Z

@Tmaster Cool, thanks! I don't have a chance to dive into this feature during these weekends but I'll start looking at it on Monday and give you my feedback ASAP.

TKul6 · 2017-12-02T11:19:04Z

HI @rychkog
I finished the indeterminate feature for the tree, you can check it out.

However there is still a little problem and I'm not sure about my solution.
While developing the feature I needed to check for a parent if one of it's children are checked, and validated it using the node id's. After a while I realized the node doesn't have to have an id which make a crazy behavior when checking a node with no id.

I temporary overcame this problem by checking if the node has a defined id, and if it doesn't I send a message to the console.

How do you recommend to solve this problem?

Thanks,
TMaster

And again, . . I'll add my tests after you approve the feature.

rychkog · 2018-02-01T11:57:28Z

@Tmaster Sorry for being silent so long - has lots of work without a chance to dedicate some time to open-source.

rychkog · 2018-02-01T11:57:58Z

I hope you still believe in a bright future of this project :)

Sign in to view

+  private updateIndeterminateStateInternal(): void {
+    const checkedChildren = this.tree.children.filter(child => child.isChecked).length;
+
+    if (checkedChildren === 0) {


Sign in to view

  public isSelected = false;
  public isRightMenuVisible = false;
  public isLeftMenuVisible = false;
+  public isChecked = false;


Sign in to view


+
+  @ViewChild('checkbox')
+  _checkboxElement: ElementRef;


Sign in to view

-                     public treeService: TreeService,
-                     public element: ElementRef) {
+    public treeService: TreeService,
+    public element: ElementRef) {


Sign in to view


-    this.settings = this.settings || { rootIsVisible: true };
+
+    this.settings = this.settings || { rootIsVisible: true, showCheckboxes: false, enableCheckboxes: true };


rychkog · 2018-02-01T12:12:14Z

@Tmaster Had a quick look and overall it is cool - will review in a bit more holistic manner today evening (my time - Eastern European Time (Standard Time))

Sign in to view

  public isSelected = false;
  public isRightMenuVisible = false;
  public isLeftMenuVisible = false;
+  public isChecked = false;


rychkog · 2018-02-11T15:33:15Z

@Tmaster I've added tests, fixed some issues in here #211. So will close this one.

TKul6 · 2018-02-11T17:50:13Z

Thanks a lot @rychkog .
Sorry about the delay, I have some things I have to close at work. no time for open source :(

rychkog · 2018-02-11T18:31:19Z

No worries - same stuff on my side :)

TMaster and others added 4 commits November 17, 2017 14:17

Support checking / unchecking nodes

4a68b64

Support readonly checkboxes

e255869

Merge branch 'develop' into adding-checkboxes

1bfe991

Fixing merge issues

6994152

TMaster added 2 commits December 2, 2017 13:02

Support indeterminated state

92a96af

Start comment with a space

f62e3b5

TKul6 mentioned this pull request Jan 24, 2018

Allows checkbox for tree nodes #79

Closed

rychkog suggested changes Feb 1, 2018

View reviewed changes

rychkog suggested changes Feb 5, 2018

View reviewed changes

Comment thread src/tree-internal.component.ts

public isSelected = false;

public isRightMenuVisible = false;

public isLeftMenuVisible = false;

public isChecked = false;

This comment was marked as off-topic.

Sign in to view

rychkog pushed a commit that referenced this pull request Feb 11, 2018

feat(tree): add checkboxes support (closes #181, closes #79)

e452727

rychkog mentioned this pull request Feb 11, 2018

Add checkboxes support #211

Merged

rychkog pushed a commit that referenced this pull request Feb 11, 2018

feat(tree): add checkboxes support (closes #181, closes #79)

5069953

rychkog closed this Feb 11, 2018


		this.settings = this.settings \|\| { rootIsVisible: true };

		this.settings = this.settings \|\| { rootIsVisible: true, showCheckboxes: false, enableCheckboxes: true };

Conversation

TKul6 commented Nov 25, 2017

Uh oh!

codecov Bot commented Nov 25, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

rychkog commented Nov 25, 2017

Uh oh!

TKul6 commented Dec 2, 2017

Uh oh!

rychkog commented Feb 1, 2018

Uh oh!

rychkog commented Feb 1, 2018

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

rychkog commented Feb 1, 2018

Uh oh!

This comment was marked as off-topic.

Uh oh!

rychkog commented Feb 11, 2018

Uh oh!

TKul6 commented Feb 11, 2018

Uh oh!

rychkog commented Feb 11, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov Bot commented Nov 25, 2017 •

edited

Loading