Commit 14abab0
committed
Query dialogs: promote the chip + popover primitives to
The Search and Selection dialogs' reusable primitives now live in `lib/ui/` and appear in Debug > Components, so David's
standard-component restyle sweep reaches them. Behavior-preserving except the one deliberate footer-button restyle.
- **`lib/ui/Dropdown.svelte`** (promoted from `filter-chips/FilterChipPopover.svelte`): the generic positioned floater
(frosted glass, auto-flip, focus trap, Esc-scoped close). Same API (`anchor` / `open` / `onClose` / `ariaLabel` /
children). Renders `.ui-dropdown` (was `.filter-chip-popover`); the host dialog's capture-phase Escape guard, the E2E
overlay-dismissal helpers, and `search-filters.spec.ts` follow the rename. `RecentItemsPopover` and the three filter
popovers now float through it.
- **`lib/ui/FilterDropdown.svelte`** (new): a thin `Dropdown` + labelled section header for the Size / Modified /
Search-in surfaces. Chosen over a `variant` prop so the generic `Dropdown` stays free of filter markup. The
`*FilterPopover` bodies thread only `anchor` / `open` / `onClose` / `label`.
- **`lib/ui/Chip.svelte`** (promoted from `filter-chips/FilterChip.svelte`): one component, two variants. `filter` keeps
the exact filter-chip look + API (popover trigger, × clear, Backspace clear, aria-expanded). `recent` replaces the
inline `<button>` pills in `RecentItemsFooter.svelte` (leading mode badge, truncating label, click, right-click
remove). Same appearance for both.
- **Footer buttons (the `size="mini"` fix, deliberate visual change):** `QueryDialog`'s primary/secondary actions ("Show
all in main window" / "Go to file" / "Select these files") and the recent footer's "All …" button are now standard
`Button` (`variant="primary|secondary"`, `size="regular"`) with the shortcut hint on a `ShortcutChip` instead of
bespoke inline spans. Dropped the now-unused `.shortcut-hint` contrast cases from the Go a11y model; `ShortcutChip`
carries its own audited contrast. Also dropped the doubled `⌘H` in Selection's trailing label (the chip renders it now).
- **Catalog:** new `Dropdown`, `FilterDropdown`, and `Chip` sections in Debug > Components, wired into the sidebar.
- **Cleanup:** deleted the orphaned `SearchFooterActions.svelte` (+ its three tests) - Search's footer renders through
`QueryDialog` from `config.{primary,secondary}Action`, not a Search-local component.
- Tier-3 a11y + behavior tests moved/added under `lib/ui/` for `Dropdown` and `Chip`; existing dialog + chip tests stay
green (4496 Svelte tests pass). Docs updated across `lib/ui`, `filter-chips`, `query-ui`, and `search`.lib/ui and standardize the footer buttons (M8)1 parent 9effb0e commit 14abab0
47 files changed
Lines changed: 940 additions & 751 deletions
File tree
- apps/desktop
- src
- lib
- query-ui
- filter-chips
- recent-items
- search
- selection-dialog
- tooltip
- ui
- routes
- debug
- dev/components
- sections
- test/e2e-playwright
- helpers
- scripts/check-a11y-contrast
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
154 | 154 | | |
155 | 155 | | |
156 | 156 | | |
157 | | - | |
158 | | - | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
159 | 160 | | |
160 | 161 | | |
161 | 162 | | |
| |||
232 | 233 | | |
233 | 234 | | |
234 | 235 | | |
235 | | - | |
236 | | - | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
237 | 240 | | |
238 | 241 | | |
239 | 242 | | |
| |||
301 | 304 | | |
302 | 305 | | |
303 | 306 | | |
304 | | - | |
305 | | - | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
306 | 312 | | |
307 | 313 | | |
308 | 314 | | |
| |||
404 | 410 | | |
405 | 411 | | |
406 | 412 | | |
407 | | - | |
| 413 | + | |
408 | 414 | | |
409 | 415 | | |
410 | | - | |
| 416 | + | |
| 417 | + | |
411 | 418 | | |
412 | 419 | | |
413 | 420 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
46 | 46 | | |
47 | 47 | | |
48 | 48 | | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
49 | 52 | | |
50 | 53 | | |
51 | 54 | | |
| |||
244 | 247 | | |
245 | 248 | | |
246 | 249 | | |
247 | | - | |
| 250 | + | |
248 | 251 | | |
249 | 252 | | |
250 | 253 | | |
| |||
928 | 931 | | |
929 | 932 | | |
930 | 933 | | |
931 | | - | |
932 | | - | |
933 | | - | |
| 934 | + | |
| 935 | + | |
934 | 936 | | |
935 | 937 | | |
936 | 938 | | |
937 | | - | |
938 | 939 | | |
939 | | - | |
940 | | - | |
941 | | - | |
942 | | - | |
943 | | - | |
| 940 | + | |
| 941 | + | |
| 942 | + | |
| 943 | + | |
| 944 | + | |
| 945 | + | |
| 946 | + | |
944 | 947 | | |
945 | 948 | | |
946 | | - | |
947 | | - | |
948 | | - | |
| 949 | + | |
| 950 | + | |
949 | 951 | | |
950 | 952 | | |
951 | 953 | | |
952 | | - | |
953 | 954 | | |
954 | | - | |
955 | | - | |
956 | | - | |
957 | | - | |
958 | | - | |
| 955 | + | |
| 956 | + | |
| 957 | + | |
| 958 | + | |
| 959 | + | |
| 960 | + | |
| 961 | + | |
959 | 962 | | |
960 | 963 | | |
961 | 964 | | |
| |||
1068 | 1071 | | |
1069 | 1072 | | |
1070 | 1073 | | |
1071 | | - | |
1072 | | - | |
1073 | | - | |
1074 | | - | |
1075 | | - | |
1076 | | - | |
1077 | | - | |
1078 | | - | |
1079 | | - | |
1080 | | - | |
1081 | | - | |
1082 | | - | |
1083 | | - | |
1084 | | - | |
| 1074 | + | |
| 1075 | + | |
| 1076 | + | |
| 1077 | + | |
| 1078 | + | |
1085 | 1079 | | |
1086 | 1080 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
319 | 319 | | |
320 | 320 | | |
321 | 321 | | |
322 | | - | |
| 322 | + | |
323 | 323 | | |
324 | 324 | | |
325 | 325 | | |
| |||
0 commit comments