Phase 2.5: Icon freshness

- Create test file generator functionality to generate file types and check icons, incl. 4 colored circle `.icns` files for custom folder icons
- Add `config.rs` for constants
- Add `get_icons_for_paths` for per-path directory icons
- Parallelize icon fetching with rayon
- Add `refresh_directory_icons`
- Add Tauri command
- Update frontend to refresh icons on directory load
- Re-fetch extension icons on each load for freshness
- Add `#![deny(unused)]` to enable dead code detection
- Add benchmark with cargo bench + criterion → Turns out the default number of threads is best.

Author: vdavid

eslint.config.js

@@ -23,7 +23,7 @@ import globals from 'globals'
 
 export default tseslint.config(
     {
-        ignores: ['dist', 'build', '.svelte-kit', 'node_modules', 'src-tauri/target'],
+        ignores: ['dist', 'build', '.svelte-kit', 'node_modules', 'src-tauri/target', '_ignored'],
     },
     js.configs.recommended,
     prettierConfig,

knip.json

@@ -1,6 +1,6 @@
 {
     "$schema": "https://unpkg.com/knip@5/schema.json",
-    "ignore": [],
+    "ignore": ["src/lib/icon-cache.ts"],
     "ignoreDependencies": ["@tauri-apps/plugin-window-state", "@testing-library/svelte"],
     "ignoreExportsUsedInFile": true
 }

scripts/test-data-generator/assets/icons/blue-circle.icns

@@ -7,6 +7,7 @@ import (
 	"fmt"
 	"math/rand"
 	"os"
+	"os/exec"
 	"path/filepath"
 	"strings"
 	"time"
@@ -203,10 +204,116 @@ func syncFolder(folderPath string, targetCount int) error {
 	return nil
 }
 
+// createIconTestData creates a folder with various file types for testing icons.
+// Includes: fake files with different extensions, symlinks, and folders with custom icons.
+func createIconTestData(baseDir string) error {
+	iconDir := filepath.Join(baseDir, "icons")
+	fmt.Printf("Creating icon test data in %s/\n", iconDir)
+
+	// Clean and recreate the folder
+	if err := os.RemoveAll(iconDir); err != nil {
+		return fmt.Errorf("failed to remove existing icon folder: %w", err)
+	}
+	if err := os.MkdirAll(iconDir, 0755); err != nil {
+		return fmt.Errorf("failed to create icon folder: %w", err)
+	}
+
+	// Create fake files with various extensions
+	fakeFiles := []string{
+		"fake-report.pdf",
+		"fake-document.docx",
+		"fake-spreadsheet.xlsx",
+		"fake-notes.txt",
+		"fake-script.ts",
+		"fake-program.go",
+		"fake-code.rs",
+		"fake-config.json",
+		"fake-data.csv",
+		"fake-archive.zip",
+		"fake-photo.jpg",
+		"fake-image.png",
+		"fake-video.mp4",
+		"fake-audio.mp3",
+		"fake-presentation.pptx",
+		"fake-database.db",
+		"fake-markup.html",
+		"fake-styles.css",
+		"fake-readme.md",
+		"fake-shell.sh",
+	}
+
+	fmt.Printf("  Creating %d fake files...\n", len(fakeFiles))
+	for _, name := range fakeFiles {
+		filePath := filepath.Join(iconDir, name)
+		content := fmt.Sprintf("This is a fake %s file for icon testing.\n", filepath.Ext(name))
+		if err := os.WriteFile(filePath, []byte(content), 0644); err != nil {
+			return fmt.Errorf("failed to create %s: %w", name, err)
+		}
+	}
+
+	// Create a symlink
+	fmt.Println("  Creating symlink...")
+	symlinkPath := filepath.Join(iconDir, "symlink-to-fake-photo.jpg")
+	if err := os.Symlink("fake-photo.jpg", symlinkPath); err != nil {
+		return fmt.Errorf("failed to create symlink: %w", err)
+	}
+
+	// Create folders with custom icons
+	assetsDir := "scripts/test-data-generator/assets/icons"
+	iconColors := []string{"red", "blue", "green", "yellow"}
+
+	fmt.Printf("  Creating %d folders with custom icons...\n", len(iconColors))
+	for _, color := range iconColors {
+		folderName := fmt.Sprintf("%s-folder", color)
+		folderPath := filepath.Join(iconDir, folderName)
+
+		if err := os.MkdirAll(folderPath, 0755); err != nil {
+			return fmt.Errorf("failed to create folder %s: %w", folderName, err)
+		}
+
+		// Create a readme inside the folder
+		readmePath := filepath.Join(folderPath, "README.md")
+		readmeContent := fmt.Sprintf("# %s Folder\n\nThis folder has a custom %s circle icon.\n", strings.Title(color), color)
+		if err := os.WriteFile(readmePath, []byte(readmeContent), 0644); err != nil {
+			return fmt.Errorf("failed to create README in %s: %w", folderName, err)
+		}
+
+		// Apply custom icon using fileicon CLI (macOS only)
+		icnsPath := filepath.Join(assetsDir, fmt.Sprintf("%s-circle.icns", color))
+		if _, err := os.Stat(icnsPath); err == nil {
+			// fileicon is available via: brew install fileicon
+			cmd := exec.Command("fileicon", "set", folderPath, icnsPath)
+			if err := cmd.Run(); err != nil {
+				fmt.Printf("  Warning: failed to set icon for %s (install fileicon: brew install fileicon)\n", folderName)
+			}
+		}
+	}
+
+	// Create a regular folder (no custom icon)
+	regularFolder := filepath.Join(iconDir, "regular-folder")
+	if err := os.MkdirAll(regularFolder, 0755); err != nil {
+		return fmt.Errorf("failed to create regular folder: %w", err)
+	}
+	if err := os.WriteFile(filepath.Join(regularFolder, "README.md"), []byte("# Regular Folder\n\nThis folder has the default macOS folder icon.\n"), 0644); err != nil {
+		return fmt.Errorf("failed to create README in regular folder: %w", err)
+	}
+
+	fmt.Println("  Icon test data created successfully!")
+	return nil
+}
+
 func main() {
 	baseDir := "_ignored/test-data"
 	fmt.Printf("Syncing test data folders in %s/\n\n", baseDir)
 
+	// Create icon test data first
+	if err := createIconTestData(baseDir); err != nil {
+		_, _ = fmt.Fprintf(os.Stderr, "Error creating icon test data: %v\n", err)
+		os.Exit(1)
+	}
+	fmt.Println()
+
+	// Sync large file count folders
 	for folderName, target := range targets {
 		folderPath := filepath.Join(baseDir, folderName)
 		if err := syncFolder(folderPath, target); err != nil {