Network: Add mounting

Author: vdavid

docs/features/network-smb/task-list.md

@@ -91,21 +91,21 @@ See [mounting.md](./mounting.md) for details.
 
 ### Backend (Rust)
 
-- ⬜ **3.1** Add NetFS.framework linking to Cargo.toml / build.rs
-- ⬜ **3.2** Create Rust bindings for `NetFSMountURLAsync`
-- ⬜ **3.3** Implement `mount_smb_share` async function
-- ⬜ **3.4** Create Tauri command: `mount_network_share`
-- ⬜ **3.5** Handle mount errors and map to user-friendly messages
-- ⬜ **3.6** Detect already-mounted shares (don't re-mount)
-- ⬜ **3.7** Add unit tests with mocked NetFS
+- ✅ **3.1** Add NetFS.framework linking to Cargo.toml / build.rs
+- ✅ **3.2** Create Rust bindings for `NetFSMountURLAsync`
+- ✅ **3.3** Implement `mount_smb_share` async function
+- ✅ **3.4** Create Tauri command: `mount_network_share`
+- ✅ **3.5** Handle mount errors and map to user-friendly messages
+- ✅ **3.6** Detect already-mounted shares (don't re-mount)
+- ✅ **3.7** Add unit tests with mocked NetFS
 
 ### Frontend (Svelte)
 
-- ⬜ **3.8** Call mount command when user selects a share
-- ⬜ **3.9** Show mounting progress/spinner
-- ⬜ **3.10** Navigate to mounted path on success
-- ⬜ **3.11** Display error messages on failure
-- ⬜ **3.12** Add frontend tests
+- ✅ **3.8** Call mount command when user selects a share
+- ✅ **3.9** Show mounting progress/spinner
+- ✅ **3.10** Navigate to mounted path on success
+- ✅ **3.11** Display error messages on failure
+- ✅ **3.12** Add frontend tests
 
 ---
 
@@ -159,7 +159,8 @@ See [known-shares-store.md](./known-shares-store.md) for details.
 
 ## 6. Pre-mounted shares
 
-Pre-mounted SMB shares (e.g., mounted via Finder) appear automatically in the volume selector because the existing volume listing code at `/Volumes/*` picks them up. The macOS APIs return the correct network share icon.
+Pre-mounted SMB shares (e.g., mounted via Finder) appear automatically in the volume selector because the existing
+volume listing code at `/Volumes/*` picks them up. The macOS APIs return the correct network share icon.
 
 ### Backend (Rust)
 

docs/todo.md

@@ -1,12 +1,16 @@
 ## Listing
 
-- Back/forward is buggy, it doesn't remember when I change volumes, and it jumps weirdly even after normal dir navi.
-- Close the volume dropdown if the user clicks outside of it.
-- VolumeBreadcrumb max height should be window max the panel size (to end within the window). If it'd be longer, make it
-  scroll.
+- Fixed? Back/forward is buggy, it doesn't remember when I change volumes, and it jumps weirdly even after normal dir
+  navi.
+- Small: Close the volume dropdown if the user clicks outside of it.
+- Small: VolumeBreadcrumb max height should be window max the panel size (to end within the window). If it'd be longer,
+  make it scroll.
 - [...] Big: Make it handle network drives (already planned out! See features/network-smb/\*)
-- Clean up `RUSTY_INJECT_TEST_SMB=1 pnpm tauri dev`, probably not needed
+- Small: Clean up `RUSTY_INJECT_TEST_SMB=1 pnpm tauri dev`, probably not needed
+- Small: Sort network hosts alphabetically
+- Small: Sort network shares alphabetically
 - [ ] Test with slow drives like network drives
+- Add settings (see below)
 - [ ] Load iCloud sync statuses, too
 - [ ] Load Google Drive sync statuses, too
 - [ ] Load OneDrive sync statuses, too?
@@ -20,12 +24,11 @@
 
 ## Cleanup / housekeeping
 
-- Add "prefer const" ESLint rule
+- Small: Add "prefer const" ESLint rule
 - A round of refactoring is due
 - Mark macOS vs generic code clearer, and add this to the guide. Is there a way to run some coherence checks for
   `#[cfg(target_os = "macos")]` == true/false separately?
 - Docs are kinda outdated
-- Upgrade to latest Rust version (1.92.0) and update dependencies
 - CSS is a mess. Probably unused rules
 
 ## Settings

src-tauri/src/commands/network.rs

@@ -212,3 +212,32 @@ pub async fn list_shares_with_credentials(
     )
     .await
 }
+
+// --- Mount Commands ---
+
+use crate::network::mount::{self, MountError, MountResult};
+
+/// Mounts an SMB share to the local filesystem.
+///
+/// Attempts to mount the specified share on the server. If credentials are
+/// provided, they are used for authentication. If the share is already mounted,
+/// returns the existing mount path without re-mounting.
+///
+/// # Arguments
+/// * `server` - Server hostname or IP address
+/// * `share` - Name of the share to mount
+/// * `username` - Optional username for authentication
+/// * `password` - Optional password for authentication
+///
+/// # Returns
+/// * `Ok(MountResult)` - Mount successful, with path to mount point
+/// * `Err(MountError)` - Mount failed with specific error type
+#[tauri::command]
+pub async fn mount_network_share(
+    server: String,
+    share: String,
+    username: Option<String>,
+    password: Option<String>,
+) -> Result<MountResult, MountError> {
+    mount::mount_share(server, share, username, password).await
+}

src-tauri/src/lib.rs

@@ -228,6 +228,8 @@ pub fn run() {
             #[cfg(target_os = "macos")]
             commands::network::list_shares_with_credentials,
             #[cfg(target_os = "macos")]
+            commands::network::mount_network_share,
+            #[cfg(target_os = "macos")]
             permissions::check_full_disk_access,
             #[cfg(target_os = "macos")]
             permissions::open_privacy_settings

src-tauri/src/network/mod.rs

@@ -6,6 +6,7 @@
 mod bonjour;
 pub mod keychain;
 pub mod known_shares;
+pub mod mount;
 pub mod smb_client;
 
 use log::{info, warn};