Transfer dialog: Always show Copy/Move toggle

Previously the segmented Copy/Move toggle only appeared when the dialog
was opened via drag-and-drop (`allowOperationToggle: true`). It's now
unconditional, so users can flip the operation regardless of how the
dialog was triggered (F5/F6, command palette, or drop). Removed the
prop from `TransferDialog`, `TransferDialogPropsData`, the
`DialogManager` pass-through, and the drag-and-drop call site, and
dropped the now-redundant a11y test for the toggle state.

Author: vdavid

apps/desktop/src/lib/file-explorer/pane/DialogManager.svelte

@@ -98,7 +98,6 @@
             sortOrder={transferDialogProps.sortOrder}
             sourceVolumeId={transferDialogProps.sourceVolumeId}
             destVolumeId={transferDialogProps.destVolumeId}
-            allowOperationToggle={transferDialogProps.allowOperationToggle}
             autoConfirm={transferDialogProps.autoConfirm}
             autoConfirmOnConflict={transferDialogProps.autoConfirmOnConflict}
             onConfirm={onTransferConfirm}

apps/desktop/src/lib/file-explorer/pane/DualPaneExplorer.svelte

@@ -776,10 +776,9 @@
         const destPath = targetFolderPath ?? getPanePath(targetPane)
         const destVolId = getPaneVolumeId(targetPane)
 
-        dialogs.showTransfer({
-            ...buildTransferPropsFromDroppedPaths(operation, paths, destPath, targetPane, destVolId, sortBy, sortOrder),
-            allowOperationToggle: true,
-        })
+        dialogs.showTransfer(
+            buildTransferPropsFromDroppedPaths(operation, paths, destPath, targetPane, destVolId, sortBy, sortOrder),
+        )
     }
 
     /** Extracts the last path component as a display name. */

apps/desktop/src/lib/file-explorer/pane/transfer-operations.ts

@@ -26,8 +26,6 @@ export interface TransferDialogPropsData {
   sortOrder: SortOrder
   sourceVolumeId: string
   destVolumeId: string
-  /** When true, shows a copy/move toggle in the transfer dialog (used for drag-and-drop). */
-  allowOperationToggle?: boolean
   /** When true, dialog auto-confirms without user interaction (MCP auto-confirm). */
   autoConfirm?: boolean
   /** Conflict resolution policy for auto-confirm (MCP). Maps to ConflictResolution. */

apps/desktop/src/lib/file-operations/transfer/TransferDialog.a11y.test.ts

@@ -2,9 +2,10 @@
  * Tier 3 a11y tests for `TransferDialog.svelte`.
  *
  * Copy/move destination picker. Volume store, Tauri IPC, and settings
- * are stubbed. Tests cover copy, move, and drag-drop (with toggle)
- * states. The dialog mounts lots of event-listener boilerplate, so
- * events return no-op unsubscribers.
+ * are stubbed. Tests cover the copy and move initial states; the
+ * copy/move toggle is always present, so both tests exercise it. The
+ * dialog mounts lots of event-listener boilerplate, so events return
+ * no-op unsubscribers.
  */
 
 import { describe, it, vi } from 'vitest'
@@ -42,7 +43,7 @@ vi.mock('$lib/stores/volume-store.svelte', () => ({
 }))
 
 describe('TransferDialog a11y', () => {
-  it('copy dialog (no toggle) has no a11y violations', async () => {
+  it('copy dialog has no a11y violations', async () => {
     const target = document.createElement('div')
     document.body.appendChild(target)
     mount(TransferDialog, {
@@ -93,31 +94,4 @@ describe('TransferDialog a11y', () => {
     await tick()
     await expectNoA11yViolations(target)
   })
-
-  it('drag-drop with copy/move toggle has no a11y violations', async () => {
-    const target = document.createElement('div')
-    document.body.appendChild(target)
-    mount(TransferDialog, {
-      target,
-      props: {
-        operationType: 'copy',
-        sourcePaths: ['/Users/test/file.txt'],
-        destinationPath: '/Users/test/dest',
-        direction: 'left',
-        currentVolumeId: 'root',
-        fileCount: 1,
-        folderCount: 0,
-        sourceFolderPath: '/Users/test',
-        sortColumn: 'name',
-        sortOrder: 'ascending',
-        sourceVolumeId: 'root',
-        destVolumeId: 'root',
-        allowOperationToggle: true,
-        onConfirm: () => {},
-        onCancel: () => {},
-      },
-    })
-    await tick()
-    await expectNoA11yViolations(target)
-  })
 })

apps/desktop/src/lib/file-operations/transfer/TransferDialog.svelte

@@ -51,8 +51,6 @@
         sourceVolumeId: string
         /** Destination volume ID */
         destVolumeId: string
-        /** When true, shows a copy/move segmented control (for drag-and-drop). */
-        allowOperationToggle?: boolean
         /** When true, dialog auto-confirms without user interaction (MCP). */
         autoConfirm?: boolean
         /** Conflict resolution policy for auto-confirm (MCP). */
@@ -84,7 +82,6 @@
         sourceVolumeId,
         // eslint-disable-next-line @typescript-eslint/no-unused-vars -- Part of Props interface, used by parent
         destVolumeId,
-        allowOperationToggle = false,
         autoConfirm = false,
         autoConfirmOnConflict,
         onConfirm,
@@ -402,21 +399,19 @@
 >
     {#snippet title()}{dialogTitle}{/snippet}
 
-    <!-- Copy/Move toggle (shown for drag-and-drop, where the user hasn't chosen yet) -->
-    {#if allowOperationToggle}
-        <div class="operation-toggle">
-            <button
-                class="toggle-option"
-                class:active={activeOperationType === 'copy'}
-                onclick={() => (activeOperationType = 'copy')}>Copy</button
-            >
-            <button
-                class="toggle-option"
-                class:active={activeOperationType === 'move'}
-                onclick={() => (activeOperationType = 'move')}>Move</button
-            >
-        </div>
-    {/if}
+    <!-- Copy/Move toggle -->
+    <div class="operation-toggle">
+        <button
+            class="toggle-option"
+            class:active={activeOperationType === 'copy'}
+            onclick={() => (activeOperationType = 'copy')}>Copy</button
+        >
+        <button
+            class="toggle-option"
+            class:active={activeOperationType === 'move'}
+            onclick={() => (activeOperationType = 'move')}>Move</button
+        >
+    </div>
 
     <!-- Direction indicator -->
     <DirectionIndicator sourcePath={sourceFolderPath} {destinationPath} {direction} />