Tooling: check for circular deps in TS code

Author: vdavid

AGENTS.md

@@ -49,7 +49,7 @@ Run the smallest set of checks possible for efficiency while maintaining confide
 - Running a Svelte test: `cd apps/desktop && pnpm vitest run -t "<test_name>"`
 - Running all Rust/Svelte tests: `./scripts/check.sh --rust` or `--svelte`
 - Running specific checks `/scripts/check.sh --check {desktop-svelte-prettier|desktop-svelte-eslint|stylelint|css-unused
-  |svelte-check|knip|type-drift|svelte-tests|desktop-smoke|e2e-linux-typecheck|desktop-e2e-linux (slow)|rustfmt|clippy
+  |svelte-check|import-cycles|knip|type-drift|svelte-tests|desktop-smoke|e2e-linux-typecheck|desktop-e2e-linux (slow)|rustfmt|clippy
   |cargo-audit|cargo-deny|cargo-udeps|jscpd-rust|cfg-gate|rust-tests|rust-tests-linux (slow)|license-server-prettier
   |license-server-eslint|license-server-typecheck|license-server-tests|gofmt|go-vet|staticcheck|ineffassign|misspell
   |gocyclo|nilaway|deadcode|go-tests|website-prettier|website-eslint|website-typecheck|website-build

apps/desktop/package.json

@@ -72,6 +72,7 @@
         "globals": "^16.5.0",
         "jsdom": "^27.4.0",
         "knip": "^5.85.0",
+        "oxlint": "^1.52.0",
         "postcss-html": "^1.8.1",
         "prettier": "^3.8.1",
         "prettier-plugin-svelte": "^3.5.1",

pnpm-lock.yaml

@@ -157,7 +157,7 @@ tests, type checkers before tests.
 | App | Tech | Checks |
 |-----|------|--------|
 | Desktop | Rust | rustfmt, clippy, cargo-audit, cargo-deny, cargo-udeps, jscpd, tests, tests-linux (slow) |
-| Desktop | Svelte | prettier, eslint, stylelint, css-unused, svelte-check, knip, type-drift, tests, smoke, e2e-linux-typecheck, e2e-linux (slow) |
+| Desktop | Svelte | prettier, eslint, stylelint, css-unused, svelte-check, import-cycles, knip, type-drift, tests, smoke, e2e-linux-typecheck, e2e-linux (slow) |
 | Website | Astro | prettier, eslint, typecheck, build, html-validate, e2e |
 | Website | Docker | docker-build |
 | License server | TS | prettier, eslint, typecheck, tests |

scripts/check/CLAUDE.md

@@ -0,0 +1,26 @@
+package checks
+
+import (
+	"fmt"
+	"os/exec"
+	"path/filepath"
+)
+
+// RunImportCycles uses oxlint's import plugin to detect circular imports in TypeScript/Svelte code.
+func RunImportCycles(ctx *CheckContext) (CheckResult, error) {
+	desktopDir := filepath.Join(ctx.RootDir, "apps", "desktop")
+
+	cmd := exec.Command("pnpm", "exec", "oxlint",
+		"--import-plugin",
+		"--allow", "all",
+		"--deny", "import/no-cycle",
+		"src",
+	)
+	cmd.Dir = desktopDir
+	output, err := RunCommand(cmd, true)
+	if err != nil {
+		return CheckResult{}, fmt.Errorf("circular imports detected\n%s", indentOutput(output))
+	}
+
+	return Success("No circular imports"), nil
+}

scripts/check/checks/desktop-svelte-import-cycles.go

@@ -133,6 +133,15 @@ var AllChecks = []CheckDefinition{
 		DependsOn:   []string{"desktop-svelte-eslint"},
 		Run:         RunSvelteCheck,
 	},
+	{
+		ID:          "desktop-svelte-import-cycles",
+		Nickname:    "import-cycles",
+		DisplayName: "import cycles (oxlint)",
+		App:         AppDesktop,
+		Tech:        "🎨 Svelte",
+		DependsOn:   nil,
+		Run:         RunImportCycles,
+	},
 	{
 		ID:          "desktop-svelte-knip",
 		Nickname:    "knip",