Commit a1d1994
committed
Pane state: skip FilePane MCP sync on Network volume
`FilePane.syncPaneStateToMcp` was pushing pane state even when the pane is on the virtual Network volume, where `NetworkMountView` / `NetworkBrowser` is the actual content owner. The push carried stale data: `files: []`, the old fixture `path`, and the leftover `totalFiles`/`loadedRange` from before the volume switch. Because `NetworkBrowser`'s own pane-state push (with the 14 host entries as `files`) raced FilePane's, and FilePane's typically pushed last, `cmdr://state` ended up frozen with empty `files`.
That's why three SMB tests (`guest/auth host shows share count`, `50-share host shows correct share count`) consistently hit their 30s `pollUntil` deadline on Linux: the state YAML never contained the host entries NetworkBrowser was correctly putting there. The tests had no `expect(result).toBe(true)` so the silent timeout looked like a pass — three dead assertions hiding a real bug.
Fix:
- Short-circuit `syncPaneStateToMcp` when `isNetworkView`. `NetworkBrowser` owns the push for that view (path `smb://`, files = hosts).
- Add the missing `expect(result).toBe(true)` to the three SMB tests so a real silent failure here fails the suite instead of disguising itself as a 30s pass.
After the fix the three tests drop from ~30.4s each (deadline hit) to ~400-800ms (actual pass). MTP is unaffected (its file list comes from a normal `list_directory`, FilePane's sync is the right source of truth there).1 parent 792bcff commit a1d1994
2 files changed
Lines changed: 22 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
870 | 870 | | |
871 | 871 | | |
872 | 872 | | |
| 873 | + | |
| 874 | + | |
| 875 | + | |
| 876 | + | |
| 877 | + | |
| 878 | + | |
| 879 | + | |
| 880 | + | |
| 881 | + | |
| 882 | + | |
| 883 | + | |
| 884 | + | |
| 885 | + | |
| 886 | + | |
| 887 | + | |
873 | 888 | | |
874 | 889 | | |
| 890 | + | |
875 | 891 | | |
876 | 892 | | |
877 | 893 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
204 | 204 | | |
205 | 205 | | |
206 | 206 | | |
207 | | - | |
| 207 | + | |
208 | 208 | | |
209 | 209 | | |
210 | 210 | | |
211 | 211 | | |
212 | 212 | | |
213 | 213 | | |
214 | 214 | | |
| 215 | + | |
215 | 216 | | |
216 | 217 | | |
217 | 218 | | |
| |||
370 | 371 | | |
371 | 372 | | |
372 | 373 | | |
373 | | - | |
| 374 | + | |
374 | 375 | | |
375 | 376 | | |
376 | 377 | | |
377 | 378 | | |
378 | 379 | | |
379 | 380 | | |
380 | 381 | | |
| 382 | + | |
381 | 383 | | |
382 | 384 | | |
383 | 385 | | |
| |||
437 | 439 | | |
438 | 440 | | |
439 | 441 | | |
440 | | - | |
| 442 | + | |
441 | 443 | | |
442 | 444 | | |
443 | 445 | | |
444 | 446 | | |
445 | 447 | | |
446 | 448 | | |
447 | 449 | | |
| 450 | + | |
448 | 451 | | |
449 | 452 | | |
450 | 453 | | |
| |||
0 commit comments