Tooling Rust: Require reasoning in lint exceptions

- Added #![warn(clippy::allow_attributes_without_reason)]
- Added reasoning everywhere

Author: vdavid

apps/desktop/src-tauri/src/benchmark.rs

@@ -4,7 +4,10 @@
 //! All events are logged to stderr with microsecond timestamps.
 
 // Benchmarks intentionally use eprintln! for raw stderr output (not log framework)
-#![allow(clippy::print_stderr)]
+#![allow(
+    clippy::print_stderr,
+    reason = "Benchmarks bypass log framework for raw stderr output"
+)]
 
 use std::sync::atomic::{AtomicBool, AtomicU64, Ordering};
 

apps/desktop/src-tauri/src/commands/file_system.rs

@@ -233,7 +233,7 @@ pub fn get_listing_stats(
 /// Logs a frontend benchmark event to stderr (unified timeline with Rust events).
 /// Only logs if RUSTY_COMMANDER_BENCHMARK=1 is set.
 #[tauri::command]
-#[allow(clippy::print_stderr)] // Benchmark output intentionally bypasses log framework
+#[allow(clippy::print_stderr, reason = "Benchmark output intentionally bypasses log framework")]
 pub fn benchmark_log(message: String) {
     if crate::benchmark::is_enabled() {
         eprintln!("{}", message);

apps/desktop/src-tauri/src/file_system/mod.rs

@@ -33,9 +33,9 @@ pub use operations::{
 #[cfg(test)]
 pub use provider::FileSystemProvider;
 // Re-export volume types (some not used externally yet)
-#[allow(unused_imports)]
+#[allow(unused_imports, reason = "Public API re-exports for future use")]
 pub use volume::{InMemoryVolume, LocalPosixVolume, Volume, VolumeError};
-#[allow(unused_imports)]
+#[allow(unused_imports, reason = "Public API re-exports for future use")]
 pub use volume_manager::VolumeManager;
 // Watcher management - init_watcher_manager must be called from lib.rs
 pub use watcher::init_watcher_manager;
@@ -60,7 +60,7 @@ pub fn init_volume_manager() {
 }
 
 /// Returns a reference to the global volume manager.
-#[allow(dead_code)] // Will be used in Phase 4.2 when commands use it
+#[allow(dead_code, reason = "Will be used in Phase 4.2 when commands use it")]
 pub fn get_volume_manager() -> &'static VolumeManager {
     &VOLUME_MANAGER
 }

apps/desktop/src-tauri/src/file_system/operations.rs

@@ -1,6 +1,6 @@
 //! File system operations: read, list, copy, move, delete.
 
-#![allow(dead_code)] // Boilerplate for future use
+#![allow(dead_code, reason = "Boilerplate for future use")]
 
 use serde::{Deserialize, Serialize};
 use std::collections::HashMap;
@@ -1267,7 +1267,7 @@ pub async fn list_directory_start_streaming(
 /// Reads a directory with progress reporting.
 ///
 /// This function runs on a blocking thread pool and emits progress events.
-#[allow(clippy::too_many_arguments)]
+#[allow(clippy::too_many_arguments, reason = "Streaming operation requires many state parameters")]
 fn read_directory_with_progress(
     app: &tauri::AppHandle,
     listing_id: &str,

apps/desktop/src-tauri/src/file_system/sync_status.rs

@@ -115,7 +115,7 @@ pub fn get_sync_statuses(paths: Vec<String>) -> HashMap<String, SyncStatus> {
 /// Gets sync status for multiple paths with configurable parallelism.
 ///
 /// Uses a Rayon thread pool with the specified number of threads.
-#[allow(dead_code)] // Used for benchmarking
+#[allow(dead_code, reason = "Used for benchmarking")]
 pub fn get_sync_statuses_with_threads(paths: Vec<String>, num_threads: usize) -> HashMap<String, SyncStatus> {
     let pool = rayon::ThreadPoolBuilder::new()
         .num_threads(num_threads)

apps/desktop/src-tauri/src/file_system/volume/in_memory.rs

@@ -13,7 +13,7 @@ use std::sync::RwLock;
 /// Entry in the in-memory file system.
 struct InMemoryEntry {
     metadata: FileEntry,
-    #[allow(dead_code)] // Will be used for future read_file support
+    #[allow(dead_code, reason = "Will be used for future read_file support")]
     content: Option<Vec<u8>>,
 }
 

apps/desktop/src-tauri/src/file_system/volume/local_posix.rs

@@ -1,8 +1,8 @@
 //! Local POSIX file system volume implementation.
 
 use super::{Volume, VolumeError};
-use crate::file_system::FileEntry;
 use crate::file_system::operations::{get_single_entry, list_directory_core};
+use crate::file_system::FileEntry;
 use std::path::{Path, PathBuf};
 
 /// A volume backed by the local POSIX file system.

apps/desktop/src-tauri/src/file_system/volume/mod.rs

@@ -4,7 +4,7 @@
 //! enabling different storage backends (local filesystem, in-memory for testing, etc.).
 
 // TODO: Remove this once Volume is integrated into operations.rs (Phase 2)
-#![allow(dead_code)]
+#![allow(dead_code, reason = "Volume abstraction not yet integrated into operations.rs")]
 
 use super::FileEntry;
 use std::path::Path;

apps/desktop/src-tauri/src/file_system/volume_manager.rs

@@ -4,7 +4,7 @@
 //! It tracks both the available volumes and which one is the current default.
 
 // TODO: Remove this once VolumeManager is used in lib.rs (Phase 4)
-#![allow(dead_code)]
+#![allow(dead_code, reason = "VolumeManager not yet integrated into lib.rs")]
 
 use super::volume::Volume;
 use std::collections::HashMap;

apps/desktop/src-tauri/src/file_system/watcher.rs

@@ -4,8 +4,9 @@
 //! Uses the unified LISTING_CACHE from operations.rs (no duplicate cache).
 
 use notify_debouncer_full::{
-    DebounceEventResult, Debouncer, RecommendedCache, new_debouncer,
+    new_debouncer,
     notify::{RecommendedWatcher, RecursiveMode},
+    DebounceEventResult, Debouncer, RecommendedCache,
 };
 use serde::{Deserialize, Serialize};
 use std::collections::HashMap;
@@ -14,7 +15,7 @@ use std::sync::{LazyLock, RwLock};
 use std::time::Duration;
 use tauri::{AppHandle, Emitter};
 
-use super::operations::{FileEntry, get_listing_entries, list_directory_core, update_listing_entries};
+use super::operations::{get_listing_entries, list_directory_core, update_listing_entries, FileEntry};
 
 /// Debounce duration in milliseconds
 const DEBOUNCE_MS: u64 = 200;
@@ -49,7 +50,7 @@ pub struct DirectoryDiff {
 /// NOTE: No `entries` field - we use the unified LISTING_CACHE instead.
 struct WatchedDirectory {
     sequence: u64,
-    #[allow(dead_code)] // Debouncer must be held to keep watching
+    #[allow(dead_code, reason = "Debouncer must be held to keep watching")]
     debouncer: Debouncer<RecommendedWatcher, RecommendedCache>,
 }