Bugfix: ⌘A selects text in the Settings and viewer windows (was dead outside the main window)

⌘A did nothing in non-main windows (for example the shortcut search field in Settings > Keyboard shortcuts). "Select all" is a custom MenuItem with a ⌘A accelerator, so macOS intercepts the keystroke before the webview ever sees it — and `handle_menu_event`'s `FileScoped` focus guard then silently dropped the event because the main window wasn't focused. No path led to the text field.

- `Select all` now rides the same focus-routed exception as Cut/Copy/Paste: main window focused → `execute-command selection.selectAll` (unchanged behavior); any other window → the native `selectAll:` selector through the responder chain via `NSApplication.sendAction:to:from:`, so WKWebView does text select-all natively, exactly like a PredefinedMenuItem would.
- `send_native_clipboard_action` renamed to `send_native_edit_action` (it's no longer clipboard-only).
- `Deselect all` (⌘⇧A) intentionally keeps the plain FileScoped path: AppKit has no standard "deselect all" responder action for text fields, so there's nothing native to forward to.
- Docs: updated the `menu/CLAUDE.md` gotchas (⌘A dual routing, custom Edit MenuItems) and the `mod.rs` mapping comments.

Author: vdavid

apps/desktop/src-tauri/src/menu/CLAUDE.md

@@ -224,21 +224,26 @@ distinction is the load-bearing reason.
   defaults that added unwanted items.
 - **Tab as accelerator**: Switch pane uses Tab, which could conflict with menu bar accessibility
   navigation. If issues arise, omit the accelerator and rely on JS dispatch.
-- **Custom MenuItems for Cut/Copy/Paste**: The Edit menu uses custom MenuItems (not
-  PredefinedMenuItems) for Cut, Copy, Paste, and Move here. In `handle_menu_event`, these are handled
-  specially: if the main window is focused, they route through `execute-command` so the frontend can
-  decide between file clipboard and text clipboard (via `document.activeElement` check). If a
-  non-main window is focused (viewer, settings), `send_native_clipboard_action()` in `menu_handlers.rs` sends
-  the native `copy:`/`cut:`/`paste:` selector through the responder chain via
+- **Custom MenuItems for Cut/Copy/Paste/Select all**: The Edit menu uses custom MenuItems (not
+  PredefinedMenuItems) for Cut, Copy, Paste, and Move here; the Select menu does the same for
+  Select all. In `handle_menu_event`, these are handled specially: if the main window is focused,
+  they route through `execute-command` so the frontend can decide between file and text semantics
+  (via `document.activeElement` check). If a non-main window is focused (viewer, settings),
+  `send_native_edit_action()` in `menu_handlers.rs` sends the native
+  `copy:`/`cut:`/`paste:`/`selectAll:` selector through the responder chain via
   `NSApplication.sendAction:to:from:`, replicating what PredefinedMenuItems do internally. This
-  ensures text clipboard works natively in all windows. Undo and Redo remain PredefinedMenuItems
-  since they only apply to text fields.
+  ensures text clipboard and text select-all work natively in all windows. Undo and Redo remain
+  PredefinedMenuItems since they only apply to text fields.
 - **⌘A dual routing**: "Select all" uses ⌘A as a native menu accelerator (so it's visible in the
   Select menu — see § "Decision: Select all and Deselect all live in the new Select top-level menu"
-  above). Since macOS intercepts it before the webview,
-  the frontend's `handleCommandExecute` checks `document.activeElement`: if it's an input/textarea, it calls `.select()`
-  for text selection; otherwise it selects files. This avoids PredefinedMenuItem::select_all which would conflict with
-  the custom MenuItem.
+  above). Since macOS intercepts it before the webview, the keystroke must be re-routed per focus:
+  main window → `execute-command`, where the frontend's `handleCommandExecute` checks
+  `document.activeElement` (input/textarea → `.select()` for text, otherwise select files);
+  non-main window → native `selectAll:` via `send_native_edit_action()` (without this branch ⌘A is
+  dead in settings text fields — the `FileScoped` focus guard would silently drop it). This avoids
+  PredefinedMenuItem::select_all which would conflict with the custom MenuItem. Deselect all (⌘⇧A)
+  stays on the plain `FileScoped` path: AppKit has no standard "deselect all" responder action for
+  text fields, so there's nothing native to forward to.
 - **Pin tab label**: `pin_tab` in MenuState is updated dynamically by the frontend to show
   "Pin tab" or "Unpin tab" based on the active tab's state.
 - **Reopen closed tab item**: The Tab submenu includes "Reopen closed tab" (⌘⇧T on macOS) between

apps/desktop/src-tauri/src/menu/menu_handlers.rs

@@ -19,10 +19,10 @@ use super::menu_items::{brief_view_label, full_view_label};
 use super::{
     CLOSE_TAB_ID, CommandScope, EDIT_COPY_ID, EDIT_CUT_ID, EDIT_PASTE_ID, EJECT_VOLUME_ID, MenuItemEntry, MenuSort,
     MenuState, NETWORK_HOST_DISCONNECT_ID, NETWORK_HOST_FORGET_PASSWORD_ID, NETWORK_HOST_FORGET_SERVER_ID,
-    SHOW_HIDDEN_FILES_ID, SORT_ASCENDING_ID, SORT_BY_CREATED_ID, SORT_BY_EXTENSION_ID, SORT_BY_MODIFIED_ID,
-    SORT_BY_NAME_ID, SORT_BY_SIZE_ID, SORT_DESCENDING_ID, SettingsChanged, TAB_CLOSE_ID, TAB_CLOSE_OTHERS_ID,
-    TAB_PIN_ID, VIEW_MODE_BRIEF_LEFT_ID, VIEW_MODE_BRIEF_RIGHT_ID, VIEW_MODE_FULL_LEFT_ID, VIEW_MODE_FULL_RIGHT_ID,
-    VIEWER_WORD_WRAP_ID, ViewMode, ViewModeChanged, menu_id_to_command,
+    SELECT_ALL_ID, SHOW_HIDDEN_FILES_ID, SORT_ASCENDING_ID, SORT_BY_CREATED_ID, SORT_BY_EXTENSION_ID,
+    SORT_BY_MODIFIED_ID, SORT_BY_NAME_ID, SORT_BY_SIZE_ID, SORT_DESCENDING_ID, SettingsChanged, TAB_CLOSE_ID,
+    TAB_CLOSE_OTHERS_ID, TAB_PIN_ID, VIEW_MODE_BRIEF_LEFT_ID, VIEW_MODE_BRIEF_RIGHT_ID, VIEW_MODE_FULL_LEFT_ID,
+    VIEW_MODE_FULL_RIGHT_ID, VIEWER_WORD_WRAP_ID, ViewMode, ViewModeChanged, menu_id_to_command,
 };
 
 /// Removes macOS system-injected items from the Edit menu and registers the Help menu.
@@ -297,24 +297,25 @@ pub fn update_menu_item_accelerator<R: Runtime>(
     Ok(())
 }
 
-/// Sends a native clipboard action (copy:/cut:/paste:) through the responder chain.
+/// Sends a native edit action (copy:/cut:/paste:/selectAll:) through the responder chain.
 ///
-/// Used when a non-main window is focused: the custom Edit menu items can't use the native
-/// responder chain like PredefinedMenuItems do, so we replicate it manually via
+/// Used when a non-main window is focused: the custom Edit/Select menu items can't use the
+/// native responder chain like PredefinedMenuItems do, so we replicate it manually via
 /// `NSApplication.sendAction:to:from:` with nil target (routes to the first responder).
 #[cfg(target_os = "macos")]
-fn send_native_clipboard_action(menu_id: &str) {
+fn send_native_edit_action(menu_id: &str) {
     use objc2::sel;
     use objc2_app_kit::NSApplication;
 
     let selector = match menu_id {
         EDIT_CUT_ID => sel!(cut:),
         EDIT_COPY_ID => sel!(copy:),
         EDIT_PASTE_ID => sel!(paste:),
+        SELECT_ALL_ID => sel!(selectAll:),
         _ => return,
     };
 
-    let mtm = objc2::MainThreadMarker::new().expect("send_native_clipboard_action must be called from the main thread");
+    let mtm = objc2::MainThreadMarker::new().expect("send_native_edit_action must be called from the main thread");
     let ns_app = NSApplication::sharedApplication(mtm);
 
     // sendAction:to:from: with nil `to` sends to the first responder, exactly like
@@ -503,30 +504,33 @@ pub fn handle_menu_event(app: &AppHandle<tauri::Wry>, event: tauri::menu::MenuEv
         return;
     }
 
-    // === Clipboard exception: file clipboard in main window, native text clipboard elsewhere ===
-    // Custom MenuItems for Cut/Copy/Paste route through execute-command in the main window
-    // so the frontend can decide between file and text clipboard. In non-main windows
-    // (viewer, settings), we send the native action through the responder chain so
-    // WKWebView handles text clipboard natively, just like PredefinedMenuItems would.
-    if id == EDIT_CUT_ID || id == EDIT_COPY_ID || id == EDIT_PASTE_ID {
+    // === Edit-action exception: file semantics in main window, native text semantics elsewhere ===
+    // Custom MenuItems for Cut/Copy/Paste/Select all route through execute-command in the main
+    // window so the frontend can decide between file and text semantics. In non-main windows
+    // (viewer, settings), we send the native action through the responder chain so WKWebView
+    // handles text clipboard / text select-all natively, just like PredefinedMenuItems would.
+    // Without the Select-all branch, ⌘A is dead in settings text fields: the accelerator fires
+    // before the webview ever sees the key, and the FileScoped focus guard would drop it.
+    if id == EDIT_CUT_ID || id == EDIT_COPY_ID || id == EDIT_PASTE_ID || id == SELECT_ALL_ID {
         let main_focused = app
             .get_webview_window("main")
             .is_some_and(|w| w.is_focused().unwrap_or(false));
         if main_focused {
             let command_id = match id {
                 EDIT_CUT_ID => "edit.cut",
                 EDIT_COPY_ID => "edit.copy",
-                _ => "edit.paste",
+                EDIT_PASTE_ID => "edit.paste",
+                _ => "selection.selectAll",
             };
             use tauri_specta::Event as _;
             let _ = crate::window_events::ExecuteCommand {
                 command_id: command_id.to_string(),
             }
             .emit_to(app, "main");
         } else {
-            // Send native clipboard action to the first responder chain
+            // Send the native action to the first responder chain
             #[cfg(target_os = "macos")]
-            send_native_clipboard_action(id);
+            send_native_edit_action(id);
         }
         return;
     }

apps/desktop/src-tauri/src/menu/mod.rs

@@ -264,9 +264,9 @@ pub fn menu_id_to_command(menu_id: &str) -> Option<(&'static str, CommandScope)>
         PIN_TAB_MENU_ID => Some(("tab.togglePin", CommandScope::FileScoped)),
         CLOSE_OTHER_TABS_ID => Some(("tab.closeOthers", CommandScope::FileScoped)),
 
-        // Clipboard operations: cut/copy/paste are handled specially in on_menu_event
-        // (native responder chain for non-main windows, execute-command for main window).
-        // They're still listed here for command_id_to_menu_id reverse lookups.
+        // Edit actions: cut/copy/paste (and select_all_files below) are handled specially in
+        // on_menu_event (native responder chain for non-main windows, execute-command for the
+        // main window). They're still listed here for command_id_to_menu_id reverse lookups.
         EDIT_CUT_ID => Some(("edit.cut", CommandScope::App)),
         EDIT_COPY_ID => Some(("edit.copy", CommandScope::App)),
         EDIT_PASTE_ID => Some(("edit.paste", CommandScope::App)),
@@ -288,6 +288,8 @@ pub fn menu_id_to_command(menu_id: &str) -> Option<(&'static str, CommandScope)>
         COPY_FILENAME_ID => Some(("file.copyFilename", CommandScope::FileScoped)),
         GET_INFO_ID => Some(("file.getInfo", CommandScope::FileScoped)),
         QUICK_LOOK_ID => Some(("file.quickLook", CommandScope::FileScoped)),
+        // Intercepted by on_menu_event before this lookup (like cut/copy/paste): main window →
+        // execute-command, non-main → native selectAll: so ⌘A still works in text fields there.
         SELECT_ALL_ID => Some(("selection.selectAll", CommandScope::FileScoped)),
         DESELECT_ALL_ID => Some(("selection.deselectAll", CommandScope::FileScoped)),
         SELECT_FILES_ID => Some(("selection.selectFiles", CommandScope::FileScoped)),