File index: Expose size-pending status via MCP

vdavid · vdavid · commit f374015202d7 · 2026-05-29T14:59:06.000+02:00
- Add `recursive_size_pending` to `PaneFileEntry`; render it as a `[size-pending]` marker on directory rows in `cmdr://state` so agents can observe the "size updating" hourglass without DOM access.
- Mirror the flag from the FE: `FilePane` includes `recursiveSizePending` in the synced pane entries, and `refreshIndexSizes` now re-syncs MCP state so the marker updates live during an index storm (not just on cursor/nav changes).
- Fill the new field in the network-browser pane entries and MCP test fixtures.
diff --git a/apps/desktop/src-tauri/src/mcp/pane_state.rs b/apps/desktop/src-tauri/src/mcp/pane_state.rs
@@ -28,6 +28,12 @@ pub struct PaneFileEntry {
     pub size: Option<u64>,
     pub recursive_size: Option<u64>,
     pub modified: Option<String>,
+    /// `Some(true)` while the indexer still has unprocessed writes affecting
+    /// this directory or a descendant, so its recursive size is mid-update.
+    /// Surfaced in `cmdr://state` as a `[size-pending]` marker so agents can
+    /// observe the "size updating" hourglass without DOM access. `None`/`false`
+    /// once the writer drains. Only meaningful for directories.
+    pub recursive_size_pending: Option<bool>,
 }
 
 /// State of a single pane.
@@ -239,6 +245,7 @@ mod tests {
                 size: Some(100),
                 recursive_size: None,
                 modified: None,
+                recursive_size_pending: None,
             }],
             cursor_index: 0,
             view_mode: "brief".to_string(),
diff --git a/apps/desktop/src-tauri/src/mcp/resources.rs b/apps/desktop/src-tauri/src/mcp/resources.rs
@@ -216,6 +216,11 @@ fn format_file_compact(
     if is_selected {
         parts.push("[sel]".to_string());
     }
+    // The recursive size is mid-update (indexer still draining writes for this
+    // dir or a descendant). Mirrors the per-row "size updating" hourglass.
+    if file.recursive_size_pending == Some(true) {
+        parts.push("[size-pending]".to_string());
+    }
 
     parts.join(" ")
 }
@@ -966,6 +971,7 @@ mod tests {
             size: Some(1024),
             recursive_size: None,
             modified: Some("2024-01-15".to_string()),
+            recursive_size_pending: None,
         };
 
         // Without details
@@ -992,6 +998,7 @@ mod tests {
             size: None,
             recursive_size: None,
             modified: None,
+            recursive_size_pending: None,
         };
         let formatted = format_file_compact(&dir, 1, false, false, false);
         assert_eq!(formatted, "i:1 d docs");
@@ -1004,9 +1011,27 @@ mod tests {
             size: None,
             recursive_size: Some(169),
             modified: Some("2026-03-19T17:33:53.000Z".to_string()),
+            recursive_size_pending: None,
         };
         let formatted = format_file_compact(&dir_with_size, 5, false, false, true);
         assert_eq!(formatted, "i:5 d src 169 B 2026-03-19T17:33:53.000Z");
+
+        // Directory whose recursive size is mid-update gets a [size-pending] marker
+        // (the "size updating" hourglass, observable without DOM access).
+        let pending_dir = PaneFileEntry {
+            name: "target".to_string(),
+            path: "/tmp/target".to_string(),
+            is_directory: true,
+            size: None,
+            recursive_size: Some(4096),
+            modified: None,
+            recursive_size_pending: Some(true),
+        };
+        let formatted = format_file_compact(&pending_dir, 2, false, false, true);
+        assert_eq!(formatted, "i:2 d target 4 KB [size-pending]");
+        // The marker shows even without details (it's a status, not a detail).
+        let formatted = format_file_compact(&pending_dir, 2, false, false, false);
+        assert_eq!(formatted, "i:2 d target [size-pending]");
     }
 
     #[test]
@@ -1023,6 +1048,7 @@ mod tests {
                     size: Some(100),
                     recursive_size: None,
                     modified: Some("2024-01-15".to_string()),
+                    recursive_size_pending: None,
                 },
                 PaneFileEntry {
                     name: "folder".to_string(),
@@ -1031,6 +1057,7 @@ mod tests {
                     size: None,
                     recursive_size: None,
                     modified: None,
+                    recursive_size_pending: None,
                 },
             ],
             cursor_index: 0,
diff --git a/apps/desktop/src-tauri/src/mcp/tests/ack_system_tests.rs b/apps/desktop/src-tauri/src/mcp/tests/ack_system_tests.rs
@@ -103,6 +103,7 @@ fn generation_gate_flips_true_after_pane_push() {
             size: None,
             recursive_size: None,
             modified: None,
+            recursive_size_pending: None,
         }],
         ..Default::default()
     });
diff --git a/apps/desktop/src-tauri/src/mcp/tests/pane_state_tests.rs b/apps/desktop/src-tauri/src/mcp/tests/pane_state_tests.rs
@@ -27,6 +27,7 @@ fn test_pane_state_store_update_left() {
             size: Some(1024),
             recursive_size: None,
             modified: Some("2024-01-01T00:00:00Z".to_string()),
+            recursive_size_pending: None,
         }],
         cursor_index: 0,
         view_mode: "brief".to_string(),
@@ -89,6 +90,7 @@ fn test_pane_state_cursor_index_bounds() {
             size: None,
             recursive_size: None,
             modified: None,
+            recursive_size_pending: None,
         }],
         cursor_index: 999, // Out of bounds
         view_mode: "brief".to_string(),
@@ -123,6 +125,7 @@ fn test_file_entry_serialization() {
         size: Some(42),
         recursive_size: None,
         modified: Some("2024-01-01T00:00:00Z".to_string()),
+        recursive_size_pending: None,
     };
 
     let json = serde_json::to_value(&entry).unwrap();
@@ -140,6 +143,7 @@ fn test_file_entry_optional_fields_serialize_as_null() {
         size: None,
         recursive_size: None,
         modified: None,
+        recursive_size_pending: None,
     };
 
     let json = serde_json::to_value(&entry).unwrap();
@@ -174,6 +178,7 @@ fn test_unicode_in_file_entries() {
         size: Some(100),
         recursive_size: None,
         modified: None,
+        recursive_size_pending: None,
     };
 
     let json = serde_json::to_value(&entry).unwrap();
@@ -191,6 +196,7 @@ fn test_special_chars_in_file_paths() {
             size: None,
             recursive_size: None,
             modified: None,
+            recursive_size_pending: None,
         },
         PaneFileEntry {
             name: "file'with'quotes.txt".to_string(),
@@ -199,6 +205,7 @@ fn test_special_chars_in_file_paths() {
             size: None,
             recursive_size: None,
             modified: None,
+            recursive_size_pending: None,
         },
         PaneFileEntry {
             name: "file\"doublequotes\".txt".to_string(),
@@ -207,6 +214,7 @@ fn test_special_chars_in_file_paths() {
             size: None,
             recursive_size: None,
             modified: None,
+            recursive_size_pending: None,
         },
     ];
 
@@ -252,6 +260,7 @@ fn test_large_file_count() {
             size: Some(i as u64 * 100),
             recursive_size: None,
             modified: None,
+            recursive_size_pending: None,
         })
         .collect();
 
diff --git a/apps/desktop/src-tauri/src/mcp/tests/security_tests.rs b/apps/desktop/src-tauri/src/mcp/tests/security_tests.rs
@@ -130,6 +130,7 @@ fn test_null_bytes_in_paths() {
         size: None,
         recursive_size: None,
         modified: None,
+        recursive_size_pending: None,
     };
 
     // Should serialize without panic
diff --git a/apps/desktop/src/lib/file-explorer/network/NetworkBrowser.svelte b/apps/desktop/src/lib/file-explorer/network/NetworkBrowser.svelte
@@ -133,7 +133,7 @@
                     size: null,
                     recursiveSize: null,
                     modified: null,
-                }
+                    recursiveSizePending: null,                }
             })
 
             // Add the "Connect to server..." pseudo-row for MCP visibility
@@ -144,7 +144,7 @@
                 size: null,
                 recursiveSize: null,
                 modified: null,
-            })
+                recursiveSizePending: null,            })
 
             const state: PaneState = {
                 path: 'smb://',
diff --git a/apps/desktop/src/lib/file-explorer/network/ShareBrowser.svelte b/apps/desktop/src/lib/file-explorer/network/ShareBrowser.svelte
@@ -129,7 +129,7 @@
                 size: null,
                 recursiveSize: null,
                 modified: null,
-            }))
+                recursiveSizePending: null,            }))
 
             const state: PaneState = {
                 path: `smb://${host.ipAddress ?? host.name}/`,
diff --git a/apps/desktop/src/lib/file-explorer/pane/FilePane.svelte b/apps/desktop/src/lib/file-explorer/pane/FilePane.svelte
@@ -985,6 +985,11 @@
         if (listingId) {
             void refreshListingIndexSizes(listingId).then(() => fetchListingStats())
         }
+        // Mirror the refreshed sizes (and the `recursiveSizePending` hourglass flag)
+        // into the MCP pane state so agents see `[size-pending]` update live during
+        // an index storm, not just on cursor/nav changes. Debounced (300ms), so a
+        // burst of index-dir-updated refreshes coalesces into one sync.
+        debouncedSyncMcp.call()
     }
 
     export function getSwapState(): SwapState {
@@ -1163,7 +1168,15 @@
         // Include ".." entry if it's in the visible range
         if (hasParent && visibleRangeStart === 0 && canonicalPath) {
             const parentPath = parentOf(canonicalPath)
-            files.push({ name: '..', path: parentPath, isDirectory: true, size: null, recursiveSize: null, modified: null })
+            files.push({
+                name: '..',
+                path: parentPath,
+                isDirectory: true,
+                size: null,
+                recursiveSize: null,
+                modified: null,
+                recursiveSizePending: null,
+            })
         }
 
         // Limit to 100 files max for performance
@@ -1186,6 +1199,7 @@
                 size: entry.size ?? null,
                 recursiveSize: entry.recursiveSize ?? null,
                 modified: entry.modifiedAt != null ? new Date(entry.modifiedAt * 1000).toISOString() : null,
+                recursiveSizePending: entry.recursiveSizePending ?? null,
             })
         }
         return files
diff --git a/apps/desktop/src/lib/ipc/bindings.ts b/apps/desktop/src/lib/ipc/bindings.ts
@@ -3097,6 +3097,14 @@ export type PaneFileEntry = {
   size: number | null
   recursiveSize: number | null
   modified: string | null
+  /**
+   *  `Some(true)` while the indexer still has unprocessed writes affecting
+   *  this directory or a descendant, so its recursive size is mid-update.
+   *  Surfaced in `cmdr://state` as a `[size-pending]` marker so agents can
+   *  observe the "size updating" hourglass without DOM access. `None`/`false`
+   *  once the writer drains. Only meaningful for directories.
+   */
+  recursiveSizePending: boolean | null
 }
 
 // State of a single pane.
